Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: Source/core/animation/AnimationEffect.h

Issue 194673002: Web Animations: Refactor KeyframeEffectModel to work via an InterpolationEffect. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@interpolationWrap
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/AnimationEffect.h
diff --git a/Source/core/animation/AnimationEffect.h b/Source/core/animation/AnimationEffect.h
index 8438c2c454d71c16278a0bb37f021e1e2bf2b98c..a75d11def4edaaf22af96d762a93a257061b7b3e 100644
--- a/Source/core/animation/AnimationEffect.h
+++ b/Source/core/animation/AnimationEffect.h
@@ -40,6 +40,7 @@
namespace WebCore {
class AnimatableValue;
+class Interpolation;
class AnimationEffect : public RefCountedWillBeGarbageCollectedFinalized<AnimationEffect> {
public:
@@ -55,12 +56,14 @@ public:
virtual ~CompositableValue() { }
virtual bool dependsOnUnderlyingValue() const = 0;
virtual PassRefPtr<AnimatableValue> compositeOnto(const AnimatableValue*) const = 0;
+
+ virtual bool isAnimatableValue() const { return false; }
};
virtual ~AnimationEffect() { }
typedef HashMap<CSSPropertyID, RefPtr<CompositableValue> > CompositableValueMap;
typedef Vector<std::pair<CSSPropertyID, RefPtr<CompositableValue> > > CompositableValueList;
alancutter (OOO until 2018) 2014/03/12 03:34:07 These two typedefs can be removed.
shans 2014/03/14 06:19:58 Done.
- virtual PassOwnPtr<CompositableValueList> sample(int iteration, double fraction) const = 0;
+ virtual PassOwnPtr<Vector<RefPtr<Interpolation> > > sample(int iteration, double fraction) const = 0;
virtual bool affects(CSSPropertyID) { return false; };
virtual bool isKeyframeEffectModel() const { return false; }

Powered by Google App Engine
This is Rietveld 408576698