Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1946723002: Fix bug in summary deserialization (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 2 chunks +32 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-03 18:53:51 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1946723002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right): https://codereview.chromium.org/1946723002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart#newcode93 pkg/analyzer/lib/src/summary/package_bundle_reader.dart:93: print('Not in summary: $result of $target ($uriString)'); We ...
4 years, 7 months ago (2016-05-03 18:56:16 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1946723002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right): https://codereview.chromium.org/1946723002/diff/1/pkg/analyzer/lib/src/summary/package_bundle_reader.dart#newcode93 pkg/analyzer/lib/src/summary/package_bundle_reader.dart:93: print('Not in summary: $result of $target ($uriString)'); Good catch, ...
4 years, 7 months ago (2016-05-03 19:03:43 UTC) #4
Brian Wilkerson
4 years, 7 months ago (2016-05-03 19:04:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
132507e95ce105928aeff4c3e3b42684a25146a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698