Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: url/url.gyp

Issue 19467002: Remove googleurl_unittests hack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/valgrind/chrome_tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/url.gyp
diff --git a/url/url.gyp b/url/url.gyp
index 5066899a4e192e486760a9f42ce952ccbde73158..a9a1a19dbfb6f2246c8760336da5579ad1a3e546 100644
--- a/url/url.gyp
+++ b/url/url.gyp
@@ -95,64 +95,5 @@
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [4267, ],
},
- {
- # url_unittests was formerly named googleurl_unittests. While the build
- # bots are being switched to use the new name we need to support both
- # executables.
- # TODO(tfarina): Remove this target when build bots are building and
- # running url_unittests. crbug.com/229660
- 'target_name': 'googleurl_unittests',
- 'type': 'none',
- 'dependencies': [
- 'url_unittests',
- ],
- 'conditions': [
- ['OS != "ios"',
- {
- 'actions': [
- {
- 'message': 'TEMPORARY: Copying url_unittests to googleurl_unittests',
- 'action_name': 'copy_url_unittests',
- 'variables': {
- 'source_file': '<(PRODUCT_DIR)/url_unittests<(EXECUTABLE_SUFFIX)',
- 'dest_file': '<(PRODUCT_DIR)/googleurl_unittests<(EXECUTABLE_SUFFIX)',
- },
- 'inputs': [
- '../build/cp.py',
- '<(source_file)',
- ],
- 'outputs': [
- '<(dest_file)',
- ],
- 'action': [
- 'python', '../build/cp.py', '<(source_file)', '<(dest_file)',
- ],
- },
- ],
- }, { # else OS == "ios"
- 'actions': [
- {
- 'message': 'TEMPORARY: Copying url_unittests to googleurl_unittests',
- 'action_name': 'copy_url_unittests',
- 'variables': {
- 'source_file': '<(PRODUCT_DIR)/url_unittests.app/',
- 'dest_file': '<(PRODUCT_DIR)/googleurl_unittests.app',
- },
- 'inputs': [
- '../build/cp.py',
- '<(source_file)',
- ],
- 'outputs': [
- '<(dest_file)',
- ],
- 'action': [
- 'cp', '-R', '<(source_file)', '<(dest_file)',
- ],
- },
- ],
- }
- ]
- ],
- },
],
}
« no previous file with comments | « tools/valgrind/chrome_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698