Remove googleurl_unittests hack.

Remove googleurl_unittests hack.

We don't need to copy url_unittests to googleurl_unittests anymore, because
the bots were already updated to run url_unittests instead of googleurl_unittests
This hack is not necessary and can be removed now.

BUG=229660
TBR=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212683

[the_wrong_timurrrr_2, 2013-07-17 07:32:28]

FYI
The Memory FYI master hasn't been restarted with the googleurl/url
replacement yet.

[tfarina, 2013-07-17 11:27:23]

On Wed, Jul 17, 2013 at 4:31 AM, Timur Iskhodzhanov <timurrrr@google.com>
wrote:
> FYI
> The Memory FYI master hasn't been restarted with the googleurl/url
> replacement yet.
What that means exactly? This affects this change overall or I just
need to back up changes in tools/?


--
Thiago

[the_wrong_timurrrr_2, 2013-07-17 11:30:28]

2013/7/17 Thiago Farina <tfarina@chromium.org>:
>> FYI
>> The Memory FYI master hasn't been restarted with the googleurl/url
>> replacement yet.
> What that means exactly? This affects this change overall
If the url_unittests binary is not copied to googleurl_unittests, the
bots will keep running a stale binary until they are clobbered.

> or I just need to back up changes in tools/?
yeah, this one too

[tfarina, 2013-07-17 11:45:17]

On Wed, Jul 17, 2013 at 8:29 AM, Timur Iskhodzhanov <timurrrr@google.com>
wrote:
So this invalidates this CL? When it will be restarted?

--
Thiago

[the_wrong_timurrrr_2, 2013-07-17 11:51:35]

2013/7/17 Thiago Farina <tfarina@chromium.org>:
> On Wed, Jul 17, 2013 at 8:29 AM, Timur Iskhodzhanov <timurrrr@google.com>
wrote:
> So this invalidates this CL?

Nope, just please wait a little bit.

> When it will be restarted?

Reid, when's it convenient for you?

> --
> Thiago

[Reid Kleckner, 2013-07-17 12:51:10]

I still see lots of references too "googleurl" in other buildbot configs:

rnk@wittenberg ~/chromium/tools/build/masters
$ ack 'googleurl' -l
master.chromium.mac/master_mac_cfg.py
master.chromium.linux/master_linux_cfg.py
master.chromium.win/master_win_cfg.py
master.chromium.memory/master_chromeos_cfg.py
master.chromium.memory/master_linux_cfg.py
master.chromium.memory/master_mac_cfg.py
master.chromium.chromiumos/master_chromiumos_cfg.py

Are you sure this is ready to go?

[tfarina, 2013-07-17 12:56:37]

googleurl or googleurl_unittests?
If the later, then I'll have to send a patch renaming these entries for
chromium/tools/build again, before landing this? I thought Robert had fixed
all this in the buildbot side.

On Wednesday, July 17, 2013, wrote:

> I still see lots of references too "googleurl" in other buildbot configs:
>
> rnk@wittenberg ~/chromium/tools/build/masters
> $ ack 'googleurl' -l
> master.chromium.mac/master_**mac_cfg.py
> master.chromium.linux/master_**linux_cfg.py
> master.chromium.win/master_**win_cfg.py
> master.chromium.memory/master_**chromeos_cfg.py
> master.chromium.memory/master_**linux_cfg.py
> master.chromium.memory/master_**mac_cfg.py
> master.chromium.chromiumos/**master_chromiumos_cfg.py
>
> Are you sure this is ready to go?
>
>
https://codereview.chromium.**org/19467002/<https://codereview.chromium.org/1...
>


-- 
Thiago

[Reid Kleckner (google), 2013-07-17 13:02:33]

Just googleurl, and I see logic in chromium_factory.py to map that onto
url_unittests.  It should be OK then.

I did the m.fyi master restart, so you should be good to go.


On Wed, Jul 17, 2013 at 8:56 AM, Thiago Farina <tfarina@chromium.org> wrote:

> googleurl or googleurl_unittests?
> If the later, then I'll have to send a patch renaming these entries for
> chromium/tools/build again, before landing this? I thought Robert had fixed
> all this in the buildbot side.
>
> On Wednesday, July 17, 2013, wrote:
>
>> I still see lots of references too "googleurl" in other buildbot configs:
>>
>> rnk@wittenberg ~/chromium/tools/build/masters
>> $ ack 'googleurl' -l
>> master.chromium.mac/master_**mac_cfg.py
>> master.chromium.linux/master_**linux_cfg.py
>> master.chromium.win/master_**win_cfg.py
>> master.chromium.memory/master_**chromeos_cfg.py
>> master.chromium.memory/master_**linux_cfg.py
>> master.chromium.memory/master_**mac_cfg.py
>> master.chromium.chromiumos/**master_chromiumos_cfg.py
>>
>> Are you sure this is ready to go?
>>
>>
https://codereview.chromium.**org/19467002/<https://codereview.chromium.org/1...
>>
>
>
> --
> Thiago
>

[tfarina, 2013-07-17 22:23:17]

Thanks Reid!

Brett, Lei, ping!

[Lei Zhang, 2013-07-17 22:32:24]

lgtm

You probably want to remove the entry from
tools/build/scripts/master/factory/chromium_factory.py as well.

[tfarina, 2013-07-19 23:06:04]

TBRing Brett for the removal in url/.

[tfarina, 2013-07-19 23:06:41]

Committed patchset #1 manually as r212683 (presubmit successful).