Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1946663002: Implement Map.unmodifiable (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement Map.unmodifiable This is a temporary solution. When we have an implementation of const maps, we should switch to that. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1cdc0221a28e039143823d76f6c510f77035674c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M lib/runtime/dart_sdk.js View 2 chunks +4 lines, -0 lines 0 comments Download
M tool/input_sdk/lib/core/map.dart View 2 chunks +17 lines, -1 line 0 comments Download
M tool/input_sdk/patch/core_patch.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 7 months ago (2016-05-03 18:32:01 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-03 18:59:24 UTC) #3
sra1
4 years, 7 months ago (2016-05-03 19:02:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1cdc0221a28e039143823d76f6c510f77035674c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698