Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 19466004: Make the copy of fontconfig font names before freeing their memory. (Closed)

Created:
7 years, 5 months ago by bungeman-skia
Modified:
7 years, 5 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make the copy of fontconfig font names before freeing their memory. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=10228

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 1 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
I noticed this issue because the FontMgr test failed on my laptop (Ubuntu 13.04), and ...
7 years, 5 months ago (2013-07-21 23:12:31 UTC) #1
reed1
lgtm
7 years, 5 months ago (2013-07-22 12:27:29 UTC) #2
bungeman-skia
Being my own worst critic, Patch Set 2 now does this completely differently. The change ...
7 years, 5 months ago (2013-07-22 14:02:21 UTC) #3
bungeman-skia
7 years, 5 months ago (2013-07-22 14:10:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r10228.

Powered by Google App Engine
This is Rietveld 408576698