Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1946583002: Avoid recreating hardware_renderer_ if a draw occurs during cleanup. (Closed)

Created:
4 years, 7 months ago by Tobias Sargeant
Modified:
4 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid recreating hardware_renderer_ if a draw occurs during cleanup. This exposed the fact that uncommitted frames were not being returned when the RTM was deleted, so this CL fixes that too. BUG=597167 Committed: https://crrev.com/9e8cbda24ddf31063e5aace07f31c2c9ffe3f8aa Cr-Commit-Position: refs/heads/master@{#391474}

Patch Set 1 #

Patch Set 2 : return uncomitted frame to BVR when RTM dies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M android_webview/browser/browser_view_renderer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/render_thread_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Tobias Sargeant
4 years, 7 months ago (2016-05-03 15:09:46 UTC) #2
boliu
lgtm
4 years, 7 months ago (2016-05-03 15:12:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946583002/1
4 years, 7 months ago (2016-05-03 15:23:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/64252)
4 years, 7 months ago (2016-05-03 16:16:07 UTC) #7
boliu
still lgtm yay for tests
4 years, 7 months ago (2016-05-03 17:10:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946583002/20001
4 years, 7 months ago (2016-05-04 09:02:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946583002/20001
4 years, 7 months ago (2016-05-04 10:43:33 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 10:47:17 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 10:49:10 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e8cbda24ddf31063e5aace07f31c2c9ffe3f8aa
Cr-Commit-Position: refs/heads/master@{#391474}

Powered by Google App Engine
This is Rietveld 408576698