Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1946553002: WebRTC's scoped_ptr and scoped_ptr.h are going away, so stop using them (Closed)

Created:
4 years, 7 months ago by kwiberg-chromium
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRTC's scoped_ptr and scoped_ptr.h are going away, so stop using them BUG=webrtc:5520 Committed: https://crrev.com/412816c08f8a2cdb5cf2b3a8a2f66c68e5661381 Cr-Commit-Position: refs/heads/master@{#391312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M content/renderer/media/peer_connection_identity_store.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/media/rtc_certificate_generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/desktop_capturer_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_capturer_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/channel_socket_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/fake_desktop_capturer.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/fake_desktop_capturer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
kwiberg-chromium
lambroslambrou@: remoting/ tommi@: the rest
4 years, 7 months ago (2016-05-03 13:43:42 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 7 months ago (2016-05-03 15:10:29 UTC) #3
Lambros
lgtm
4 years, 7 months ago (2016-05-03 17:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946553002/1
4 years, 7 months ago (2016-05-03 18:39:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:45:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:48:23 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/412816c08f8a2cdb5cf2b3a8a2f66c68e5661381
Cr-Commit-Position: refs/heads/master@{#391312}

Powered by Google App Engine
This is Rietveld 408576698