appengine/findit/model/crash/crash_analysis.py - Issue 1946513003: [Findit] Modify the handler for fracas input message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/crash/crash_analysis.py

Issue 1946513003: [Findit] Modify the handler for fracas input message. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comment. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/crash/fracas_crash_pipeline.py ('K') | « appengine/findit/handlers/crash/test/fracas_crash_test.py ('k') | appengine/findit/model/crash/fracas_crash_analysis.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/model/crash/crash_analysis.py

diff --git a/appengine/findit/model/crash/crash_analysis.py b/appengine/findit/model/crash/crash_analysis.py

index d98ae4975407b20a9371f405ab8e1ee5d17f16eb..236208d4354e8e691ba6a10ace4b78566a8e4121 100644

--- a/appengine/findit/model/crash/crash_analysis.py

+++ b/appengine/findit/model/crash/crash_analysis.py

@@ -8,7 +8,7 @@ from model import analysis_status

class CrashAnalysis(ndb.Model):

- """Base class to represent an analysis of a Chrome crash."""

+ """Base class to represent an analysis of a Chrome/Clusterfuzz crash."""

################### Properties for the crash itself. ###################

# In which version or revision of Chrome the crash occurred. Either a version

# number for Chrome build or a git commit hash/position for chromium build.

@@ -20,6 +20,12 @@ class CrashAnalysis(ndb.Model):

# The signature of the crash.

signature = ndb.StringProperty(indexed=False)

+ # The platform of this crash.

+ platform = ndb.StringProperty(indexed=False)

+ # ID to differentiate different client.

+ client_id = ndb.StringProperty(indexed=False)

################### Properties for the analysis progress. ###################

# The url path to the pipeline status page.