Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 1946413002: Avoid overflow recalc on tables if sections need rebuild (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 section->updateLayerTransformAfterLayout(); 402 section->updateLayerTransformAfterLayout();
403 section->addVisualEffectOverflow(); 403 section->addVisualEffectOverflow();
404 } 404 }
405 } 405 }
406 406
407 bool LayoutTable::recalcChildOverflowAfterStyleChange() 407 bool LayoutTable::recalcChildOverflowAfterStyleChange()
408 { 408 {
409 ASSERT(childNeedsOverflowRecalcAfterStyleChange()); 409 ASSERT(childNeedsOverflowRecalcAfterStyleChange());
410 clearChildNeedsOverflowRecalcAfterStyleChange(); 410 clearChildNeedsOverflowRecalcAfterStyleChange();
411 411
412 // If the table needs layout the sections we keep pointers to may have gone away and 412 // If the table sections we keep pointers to have gone away then the table w ill be rebuilt and
413 // overflow will get recalculated anyway so return early. 413 // overflow will get recalculated anyway so return early.
414 if (needsLayout()) 414 if (needsSectionRecalc())
415 return false; 415 return false;
416 416
417 bool childrenOverflowChanged = false; 417 bool childrenOverflowChanged = false;
418 for (LayoutTableSection* section = topSection(); section; section = sectionB elow(section)) { 418 for (LayoutTableSection* section = topSection(); section; section = sectionB elow(section)) {
419 if (!section->childNeedsOverflowRecalcAfterStyleChange()) 419 if (!section->childNeedsOverflowRecalcAfterStyleChange())
420 continue; 420 continue;
421 childrenOverflowChanged |= section->recalcChildOverflowAfterStyleChange( ); 421 childrenOverflowChanged |= section->recalcChildOverflowAfterStyleChange( );
422 } 422 }
423 return childrenOverflowChanged; 423 return childrenOverflowChanged;
424 } 424 }
(...skipping 1049 matching lines...) Expand 10 before | Expand all | Expand 10 after
1474 1474
1475 LayoutUnit LayoutTable::paddingRight() const 1475 LayoutUnit LayoutTable::paddingRight() const
1476 { 1476 {
1477 if (collapseBorders()) 1477 if (collapseBorders())
1478 return LayoutUnit(); 1478 return LayoutUnit();
1479 1479
1480 return LayoutBlock::paddingRight(); 1480 return LayoutBlock::paddingRight();
1481 } 1481 }
1482 1482
1483 } // namespace blink 1483 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698