third_party/WebKit/LayoutTests/fast/repaint/checkbox-selection-rect-in-cell.html - Issue 1946413002: Avoid overflow recalc on tables if sections need rebuild

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/repaint/checkbox-selection-rect-in-cell.html

Issue 1946413002: Avoid overflow recalc on tables if sections need rebuild (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/repaint/checkbox-selection-rect-in-cell-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/repaint/checkbox-selection-rect-in-cell-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="resources/text-based-repaint.js"></script>

	3 <script>

	4 function repaintTest() {

	5 document.getElementById("b").focus();

	6 document.getElementById("a").focus();
	Xianzhu 2016/05/05 16:01:33 What will these affect? Why two focus calls? What will these affect? Why two focus calls? rhogan 2016/05/05 18:30:10 I want to mimic the effect of #b gaining then losi Show quoted text On 2016/05/05 at 16:01:33, Xianzhu wrote: > What will these affect? Why two focus calls? I want to mimic the effect of #b gaining then losing focus - so I can show that the repaints of the focus ring are effective. Xianzhu 2016/05/05 18:35:49 Does it really work to focus and unfocus in the sa Show quoted text On 2016/05/05 18:30:10, rhogan wrote: > On 2016/05/05 at 16:01:33, Xianzhu wrote: > > What will these affect? Why two focus calls? > > I want to mimic the effect of #b gaining then losing focus - so I can show that > the repaints of the focus ring are effective. Does it really work to focus and unfocus in the same cycle? What will this test produce without the patch?
	7 }

	8 onload = runRepaintTest;

	9 </script>

	10 <p>crbug.com/609018: Only avoid calc'ing overflow if a table's sections may have been deleted.</p>

	11 <table>

	12 <tr>

	13 <td>

	14 <a href="#" id="a">Text</a>

	15 <input id="b" type="checkbox">

	16 </td>

	17 </tr>

	18 </table>

OLD	NEW