Replaces Location::ToStackSlotAddress() with Location::ToStackSlotOffset()

runtime/vm/locations.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_LOCATIONS_H_
 #define VM_LOCATIONS_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/bitfield.h"
@@ skipping 263 matching lines @@
   bool IsQuadStackSlot() const {
     return kind() == kQuadStackSlot;
   }
 
   intptr_t stack_index() const {
     ASSERT(IsStackSlot() || IsDoubleStackSlot() || IsQuadStackSlot());
     // Decode stack index manually to preserve sign.
     return payload() - kStackIndexBias;
   }
 
-  // Return a memory operand for stack slot locations.
-  Address ToStackSlotAddress() const;
+  // Returns the offset from the frame pointer for stack slot locations.
+  intptr_t ToStackSlotOffset() const;

[regis, 2013/07/17 16:35:19]

You could add this new function, while leaving ToStackSlotAddress() untouched.
The IA32 and X64 code generator could continue using the old one, while ARM and
MIPS could use the new one when the offset may be out of range (LoadFromOffset
and StoreToOffset are used instead).

 
   // Constants.
   static Location RegisterOrConstant(Value* value);
   static Location RegisterOrSmiConstant(Value* value);
   static Location FixedRegisterOrConstant(Value* value, Register reg);
   static Location FixedRegisterOrSmiConstant(Value* value, Register reg);
   static Location AnyOrConstant(Value* value);
 
   const char* Name() const;
   void PrintTo(BufferFormatter* f) const;
@@ skipping 183 matching lines @@
   BitmapBuilder* stack_bitmap_;
 
   const ContainsCall contains_call_;
   RegisterSet live_registers_;
 };
 
 
 }  // namespace dart
 
 #endif  // VM_LOCATIONS_H_