Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1946373002: Add missing remoting tests to gn build (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing remoting tests to gn build Some .cc files are missing from the .gn build. Adding a few of them. BUG=604060 Committed: https://crrev.com/715326a623d42be037eca4c333d9e746eca03ddb Cr-Commit-Position: refs/heads/master@{#391631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M remoting/client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
These tests are missing from gn builds, which seems bad. PTAL.
4 years, 7 months ago (2016-05-04 19:17:58 UTC) #2
Jamie
lgtm
4 years, 7 months ago (2016-05-04 19:49:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946373002/1
4 years, 7 months ago (2016-05-04 19:50:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 20:47:29 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:48:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/715326a623d42be037eca4c333d9e746eca03ddb
Cr-Commit-Position: refs/heads/master@{#391631}

Powered by Google App Engine
This is Rietveld 408576698