Issue 26355. Don't overwrite full index with declarations-only one.

Issue 26355. Don't overwrite full index with declarations-only one.

What happens in this case is that when we analyze this project with
many (very small) files, we successfully index first declarations
(on computing RESOLVED_UNIT3) and then RESOLVED_UNIT. But when we attempt
to search, we ask for RESOLVED_UNIT, which is flushed. So, we compute it.
In the process we compute RESOLVED_UNIT3, and the listener in
_setupIndexInvalidation() indexes declarations, and overwrites the full
index.

There are several possible solutions, the simplest one is to not
overwrite any existing index information while indexing declarations.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26355

Committed: https://github.com/dart-lang/sdk/commit/ada9cf43db62a35f63ef75286f3f14aebe222310

[Brian Wilkerson, 2016-05-05 13:16:56]

lgtm

[scheglov, 2016-05-05 14:10:17]

Description was changed from

==========
Issue 26355. Don't overwrite full index with declarations-only one.

What happens in this case is that when we analyze this project with
many (very small) files, we successfully index first declarations
(on computing RESOLVED_UNIT3) and then RESOLVED_UNIT. But when we attempt
to search, we ask for RESOLVED_UNIT, which is flushed. So, we compute it.
In the process we compute RESOLVED_UNIT3, and the listener in
_setupIndexInvalidation() indexes declarations, and overwrites the full
index.

There are several possible solutions, the simplest one is to not
overwrite any existing index information while indexing declarations.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26355
==========

to

==========
Issue 26355. Don't overwrite full index with declarations-only one.

What happens in this case is that when we analyze this project with
many (very small) files, we successfully index first declarations
(on computing RESOLVED_UNIT3) and then RESOLVED_UNIT. But when we attempt
to search, we ask for RESOLVED_UNIT, which is flushed. So, we compute it.
In the process we compute RESOLVED_UNIT3, and the listener in
_setupIndexInvalidation() indexes declarations, and overwrites the full
index.

There are several possible solutions, the simplest one is to not
overwrite any existing index information while indexing declarations.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26355

Committed:
https://github.com/dart-lang/sdk/commit/ada9cf43db62a35f63ef75286f3f14aebe222310
==========

[scheglov, 2016-05-05 14:10:18]

Committed patchset #1 (id:1) manually as
ada9cf43db62a35f63ef75286f3f14aebe222310 (presubmit successful).