Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1946343002: Move computeSelfHitTestRects() to LayoutBlockFlow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 public: 365 public:
366 virtual void computeOverflow(LayoutUnit oldClientAfterEdge, bool = false); 366 virtual void computeOverflow(LayoutUnit oldClientAfterEdge, bool = false);
367 protected: 367 protected:
368 virtual void addOverflowFromChildren(); 368 virtual void addOverflowFromChildren();
369 void addOverflowFromPositionedObjects(); 369 void addOverflowFromPositionedObjects();
370 void addOverflowFromBlockChildren(); 370 void addOverflowFromBlockChildren();
371 void addVisualOverflowFromTheme(); 371 void addVisualOverflowFromTheme();
372 372
373 void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffse t, IncludeBlockVisualOverflowOrNot) const override; 373 void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffse t, IncludeBlockVisualOverflowOrNot) const override;
374 374
375 void computeSelfHitTestRects(Vector<LayoutRect>&, const LayoutPoint& layerOf fset) const override;
376
377 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, LayoutBox& ); 375 void updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, LayoutBox& );
378 376
379 // TODO(jchaffraix): We should rename this function as inline-flex and inlin e-grid as also covered. 377 // TODO(jchaffraix): We should rename this function as inline-flex and inlin e-grid as also covered.
380 // Alternatively it should be removed as we clarify the meaning of isAtomicI nlineLevel to imply 378 // Alternatively it should be removed as we clarify the meaning of isAtomicI nlineLevel to imply
381 // isInline. 379 // isInline.
382 bool isInlineBlockOrInlineTable() const final { return isInline() && isAtomi cInlineLevel(); } 380 bool isInlineBlockOrInlineTable() const final { return isInline() && isAtomi cInlineLevel(); }
383 381
384 void invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidat ionContainer, PaintInvalidationReason) const override; 382 void invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidat ionContainer, PaintInvalidationReason) const override;
385 383
386 private: 384 private:
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
508 // FIXME: This is temporary as we move code that accesses block flow 506 // FIXME: This is temporary as we move code that accesses block flow
509 // member variables out of LayoutBlock and into LayoutBlockFlow. 507 // member variables out of LayoutBlock and into LayoutBlockFlow.
510 friend class LayoutBlockFlow; 508 friend class LayoutBlockFlow;
511 }; 509 };
512 510
513 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 511 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
514 512
515 } // namespace blink 513 } // namespace blink
516 514
517 #endif // LayoutBlock_h 515 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698