Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1946303002: S390: Add HasProperty code stub that tries simple lookups or jumps to runtime otherwise. (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Add HasProperty code stub that tries simple lookups or jumps to runtime otherwise. Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler. R=ishell@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:2743 LOG=Y Committed: https://crrev.com/e9b244c58a8dc45e9dca9a1496f301c3ed1ba385 Cr-Commit-Position: refs/heads/master@{#36037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-04 17:43:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946303002/1
4 years, 7 months ago (2016-05-04 17:43:24 UTC) #3
Igor Sheludko
lgtm
4 years, 7 months ago (2016-05-04 17:54:03 UTC) #4
Igor Sheludko
On 2016/05/04 17:54:03, Igor Sheludko wrote: > lgtm Thanks!
4 years, 7 months ago (2016-05-04 17:54:12 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 18:09:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946303002/1
4 years, 7 months ago (2016-05-04 18:31:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 18:34:05 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:36:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9b244c58a8dc45e9dca9a1496f301c3ed1ba385
Cr-Commit-Position: refs/heads/master@{#36037}

Powered by Google App Engine
This is Rietveld 408576698