Issue 19463010: Revert 212008 "cc: Remove TextureLayer::SetTextureId and Texture..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19463010: Revert 212008 "cc: Remove TextureLayer::SetTextureId and Texture..." (Closed)

Created:
7 years, 5 months ago by aberent

Modified:
7 years, 5 months ago

Reviewers:
piman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 212008 "cc: Remove TextureLayer::SetTextureId and Texture..." Temporary revert of this as Android Build Sheriff until the Android UI stops using SetTextureId. Needed since it is currently impossible to roll the version of chromium used by Android past this change. > cc: Remove TextureLayer::SetTextureId and TextureLayer::WillModifyTexture > > These are not used anymore except for clearing the client-provided texture, so > this removes 1 of 4 TextureLayer paths, and implifies externally-exposed state. > > BUG=None > > Review URL: https://chromiumcodereview.appspot.com/19303003 BUG=261151 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212321

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -257 lines)			Patch
M	trunk/src/cc/layers/texture_layer.h	View	4 chunks	+6 lines, -13 lines	0 comments	Download
M	trunk/src/cc/layers/texture_layer.cc	View	7 chunks	+23 lines, -25 lines	0 comments	Download
M	trunk/src/cc/layers/texture_layer_unittest.cc	View	10 chunks	+123 lines, -216 lines	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/compositor/layer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/webkit/renderer/compositor_bindings/web_external_texture_layer_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r212321.

Expand Messages | Collapse Messages