Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Issue 1946293002: travis: verify out-of-tree builds & dist targets (Closed)

Created:
4 years, 7 months ago by vapier
Modified:
4 years, 7 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

travis: verify out-of-tree builds & dist targets Required updating a lot of dist files in the process. R=ted.mielczarek@gmail.com Committed: https://chromium.googlesource.com/breakpad/breakpad/+/983d04d36eb8f6b23f7e3932a39a4087c4e1bab2

Patch Set 1 #

Patch Set 2 : add more files to the dist #

Total comments: 1

Patch Set 3 : update filelist after recent commits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -165 lines) Patch
M Makefile.am View 1 2 14 chunks +212 lines, -61 lines 0 comments Download
M Makefile.in View 1 2 35 chunks +281 lines, -104 lines 0 comments Download
M scripts/travis-build.sh View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vapier
seems like the last time the dist was checked was 2009 :). this passes on ...
4 years, 7 months ago (2016-05-04 18:51:32 UTC) #2
Ted Mielczarek
I'm on vacation for the next week, so you can tag someone else for review ...
4 years, 7 months ago (2016-05-04 19:23:51 UTC) #3
vapier
shouldn't be a problem to wait. just something i noticed.
4 years, 7 months ago (2016-05-04 21:51:52 UTC) #4
vapier
friendly ping :)
4 years, 7 months ago (2016-05-25 15:50:07 UTC) #5
Ted Mielczarek
lgtm https://codereview.chromium.org/1946293002/diff/20001/Makefile.am File Makefile.am (right): https://codereview.chromium.org/1946293002/diff/20001/Makefile.am#newcode167 Makefile.am:167: src/client/linux/handler/exception_handler.h \ I guess we haven't been keeping ...
4 years, 7 months ago (2016-05-25 17:57:03 UTC) #6
vapier
4 years, 7 months ago (2016-05-25 18:36:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
983d04d36eb8f6b23f7e3932a39a4087c4e1bab2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698