Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1946273003:
Roll buildtools to 731bdb2af8b5839450605ddebdcf5de749cf9d17 (Closed)
DescriptionRoll buildtools to 731bdb2af8b5839450605ddebdcf5de749cf9d17
731bdb2 [sanitizers] supporting libc++ asan build on mac.
b4232ff Always set symbol visibility when compiling with GCC / Clang.
431de63 Properly configure patch project for trybot usage
BUG=597066
Committed: https://crrev.com/6ef929b6651816a5fb17e912dc44c02529c42a24
Cr-Commit-Position: refs/heads/master@{#391696}
Patch Set 1 #Patch Set 2 : excluding gn roll. #Messages
Total messages: 19 (8 generated)
aizatsky@chromium.org changed reviewers: + brettw@chromium.org, dpranke@chromium.org, rsesek@chromium.org
I did this manually. Not sure if a tool exists.
The CQ bit was checked by aizatsky@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946273003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
Brett,
This change fails on trybots because of:
ERROR at //build/toolchain/gcc_toolchain.gni:417:32: Clobbering existing value.
"symbol_level",
^-------------
The current scope already defines a value "symbol_level".
forward_variables_from() won't clobber existing values. If you want to
merge lists, you'll need to do this explicitly.
See build arg file (use "gn args <out_dir>" to edit):19:16: value being
clobbered.
symbol_level = 1
(https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy...)
This looks to be related to
https://chromium.googlesource.com/chromium/src/+/0785c950dce7221b10c21e911795...
Is this because of "Roll gn" change? I can remove it from this roll, I only need
my [sanitizers] change.
Yup, that's due to the 'Roll gn' change. I would ping brettw@ and see if he wants you to revert the GN change. I think he has another patch in flight that might fix these things. You can roll buildtools in a semi-automated way by running `python tools/gn/bin/roll_gn.py roll_buildtools`, but it looks like your manual attempt was close enough :).
Description was changed from ========== Roll buildtools to 309289315767f615256eada4653b4917cf148c8e 3092893 Roll gn 6d7b5d9014..32be261298 (r389592:r391459) 731bdb2 [sanitizers] supporting libc++ asan build on mac. b4232ff Always set symbol visibility when compiling with GCC / Clang. 431de63 Properly configure patch project for trybot usage BUG=597066 ========== to ========== Roll buildtools to 731bdb2af8b5839450605ddebdcf5de749cf9d17 731bdb2 [sanitizers] supporting libc++ asan build on mac. b4232ff Always set symbol visibility when compiling with GCC / Clang. 431de63 Properly configure patch project for trybot usage BUG=597066 ==========
The CQ bit was checked by aizatsky@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946273003/20001
On 2016/05/04 at 22:08:05, dpranke wrote: > Yup, that's due to the 'Roll gn' change. I would ping brettw@ and see if he wants you to revert the GN change. I think he has another patch in flight that might fix these things. > > You can roll buildtools in a semi-automated way by running `python tools/gn/bin/roll_gn.py roll_buildtools`, but it looks like your manual attempt was close enough :). I excluded latest "Roll gn" change to make it easier to land this one.
lgtm, then.
The CQ bit was unchecked by aizatsky@chromium.org
The CQ bit was checked by aizatsky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946273003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools to 731bdb2af8b5839450605ddebdcf5de749cf9d17 731bdb2 [sanitizers] supporting libc++ asan build on mac. b4232ff Always set symbol visibility when compiling with GCC / Clang. 431de63 Properly configure patch project for trybot usage BUG=597066 ========== to ========== Roll buildtools to 731bdb2af8b5839450605ddebdcf5de749cf9d17 731bdb2 [sanitizers] supporting libc++ asan build on mac. b4232ff Always set symbol visibility when compiling with GCC / Clang. 431de63 Properly configure patch project for trybot usage BUG=597066 Committed: https://crrev.com/6ef929b6651816a5fb17e912dc44c02529c42a24 Cr-Commit-Position: refs/heads/master@{#391696} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6ef929b6651816a5fb17e912dc44c02529c42a24 Cr-Commit-Position: refs/heads/master@{#391696} |
