swarming: refactor cipd input

appengine/swarming/swarming_rpcs.py

Index: appengine/swarming/swarming_rpcs.py
diff --git a/appengine/swarming/swarming_rpcs.py b/appengine/swarming/swarming_rpcs.py
index b9f61c49be939eb7e19bb2c80fd987a54a2f3060..75cf0986aa56d3b1c793b4e5f47e5c05fa09c756 100644
--- a/appengine/swarming/swarming_rpcs.py
+++ b/appengine/swarming/swarming_rpcs.py
@@ -84,14 +84,37 @@ class FilesRef(messages.Message):
 
 class CipdPackage(messages.Message):
   """A CIPD package to install in $CIPD_PATH and $PATH before task execution."""
-  # Full CIPD package name, e.g. "infra/tools/authutil/linux-amd64"
+  # A template of a full CIPD package name, e.g.
+  # "infra/tools/authutil/${platform}"
+  # See also cipd.ALL_PARAMS.
   package_name = messages.StringField(1)
-  # Instance ID, tag or ref, e.g. "latest".
+  # Valid package version for all packages matched by package name.
   version = messages.StringField(2)
 
 
+class CipdInput(messages.Message):
+  """Defines CIPD packages to install in $CIPD_PATH.
+
+  A command may use $CIPD_PATH in its arguments. It will be expanded to the path
+  of the CIPD site root.
+  """
+  # URL of the CIPD server. Must start with "https://" or "http://".
+  # This field or its subfields are optional if default cipd client is defined
+  # in the server config.
+  server = messages.StringField(1)
+
+  # CIPD package of CIPD client to use.
+  # client_package.version is required.
+  # This field is optional is default value is defined in the server config.
+  client_package = messages.MessageField(CipdPackage, 2)
+
+  # List of CIPD packages to install in $CIPD_PATH prior task execution.
+  packages = messages.MessageField(CipdPackage, 3, repeated=True)
+
+
 class TaskProperties(messages.Message):
   """Important metadata about a particular task."""
+  cipd_input = messages.MessageField(CipdInput, 10)

[M-A Ruel, 2016/05/12 13:49:45]

For the record, I'm only allowing it because there was no known use of item #10,
this is not good hygiene but we can get away with it now since we never used the
protobuf format.

[nodir, 2016/05/12 18:00:28]

do you prefer to renumber all fields? I am fine with that

[M-A Ruel, 2016/05/12 18:48:05]

No, renumbering is also bad protobuf hygiene.

We just get away with it this time. :)

   command = messages.StringField(1, repeated=True)
   dimensions = messages.MessageField(StringPair, 2, repeated=True)
   env = messages.MessageField(StringPair, 3, repeated=True)
@@ -101,7 +124,6 @@ class TaskProperties(messages.Message):
   idempotent = messages.BooleanField(7)
   inputs_ref = messages.MessageField(FilesRef, 8)
   io_timeout_secs = messages.IntegerField(9)
-  packages = messages.MessageField(CipdPackage, 10, repeated=True)
 
 
 class NewTaskRequest(messages.Message):