Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1946213003: Remove CLASSHASH defines in favour of an enum class. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CLASSHASH defines in favour of an enum class. This Cl updates all the CLASSHASH defines to use an enum class. A few defines where unabled and were either updated or removed if the number no longer exists in the code base. Committed: https://pdfium.googlesource.com/pdfium/+/b4d40ffae3f955fab2fac838430c89aca452c45f

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 24

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -508 lines) Patch
M xfa/fwl/basewidget/fwl_barcodeimp.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_barcodeimp.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.h View 1 3 chunks +22 lines, -18 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.h View 1 4 chunks +20 lines, -12 lines 0 comments Download
M xfa/fwl/basewidget/fwl_checkboximp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.h View 1 3 chunks +64 lines, -56 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.h View 1 1 chunk +37 lines, -34 lines 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.cpp View 1 3 chunks +9 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 3 chunks +12 lines, -7 lines 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.h View 1 1 chunk +12 lines, -9 lines 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.h View 1 3 chunks +23 lines, -19 lines 0 comments Download
M xfa/fwl/basewidget/fwl_listboximp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.h View 1 2 chunks +18 lines, -15 lines 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pictureboximp.h View 1 3 chunks +15 lines, -10 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pictureboximp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.h View 1 3 chunks +16 lines, -11 lines 0 comments Download
M xfa/fwl/basewidget/fwl_pushbuttonimp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.h View 1 3 chunks +32 lines, -24 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.h View 1 2 chunks +19 lines, -12 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.h View 1 2 chunks +30 lines, -21 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_barcode.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_caret.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_checkbox.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_combobox.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_datetimepicker.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_edit.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_listbox.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_monthcalendar.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_picturebox.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_pushbutton.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_scrollbar.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_spinbutton.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_tooltip.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_formimp.h View 1 1 chunk +23 lines, -21 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 3 chunks +6 lines, -5 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 1 4 chunks +12 lines, -21 lines 0 comments Download
M xfa/fwl/core/fwl_widgetmgrimp.cpp View 1 6 chunks +7 lines, -44 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/core/ifwl_themeprovider.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/ifwl_widget.h View 1 2 chunks +21 lines, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_theme.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_theme.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_widget.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_barcodetp.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_barcodetp.cpp View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_carettp.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_carettp.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.h View 1 2 1 chunk +11 lines, -9 lines 0 comments Download
M xfa/fwl/theme/cfwl_checkboxtp.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_comboboxtp.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_comboboxtp.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_datetimepickedtp.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_datetimepickertp.h View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_edittp.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_edittp.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_formtp.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_formtp.cpp View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_listboxtp.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_listboxtp.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_pictureboxtp.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/fwl/theme/cfwl_pictureboxtp.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.h View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M xfa/fwl/theme/cfwl_scrollbartp.cpp View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 1 2 5 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-04 20:56:55 UTC) #2
Tom Sepez
https://codereview.chromium.org/1946213003/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h File xfa/fwl/basewidget/fwl_barcodeimp.h (right): https://codereview.chromium.org/1946213003/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h#newcode29 xfa/fwl/basewidget/fwl_barcodeimp.h:29: FWL_Type GetClassID() const override { return FWL_Type::Barcode; } Might ...
4 years, 7 months ago (2016-05-04 22:28:43 UTC) #3
dsinclair
https://codereview.chromium.org/1946213003/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h File xfa/fwl/basewidget/fwl_barcodeimp.h (right): https://codereview.chromium.org/1946213003/diff/1/xfa/fwl/basewidget/fwl_barcodeimp.h#newcode29 xfa/fwl/basewidget/fwl_barcodeimp.h:29: FWL_Type GetClassID() const override { return FWL_Type::Barcode; } On ...
4 years, 7 months ago (2016-05-05 13:44:18 UTC) #4
Tom Sepez
Maybe IsValidWidget() can return bool, not FX_BOOL. LGTM with question, nits. https://codereview.chromium.org/1946213003/diff/20001/xfa/fwl/core/fwl_widgetmgrimp.cpp File xfa/fwl/core/fwl_widgetmgrimp.cpp (left): ...
4 years, 7 months ago (2016-05-05 16:56:48 UTC) #5
dsinclair
https://codereview.chromium.org/1946213003/diff/20001/xfa/fwl/core/fwl_widgetmgrimp.cpp File xfa/fwl/core/fwl_widgetmgrimp.cpp (left): https://codereview.chromium.org/1946213003/diff/20001/xfa/fwl/core/fwl_widgetmgrimp.cpp#oldcode466 xfa/fwl/core/fwl_widgetmgrimp.cpp:466: pChild->GetClassID() == 3811304691) { Git diff master and searching ...
4 years, 7 months ago (2016-05-05 17:13:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946213003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946213003/40001
4 years, 7 months ago (2016-05-05 17:13:55 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 17:28:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b4d40ffae3f955fab2fac838430c89aca452...

Powered by Google App Engine
This is Rietveld 408576698