[GN/iOS/Mac] Decouple copy_bundle_data from gyp mac_tool.py.

[GN/iOS/Mac] Decouple copy_bundle_data from gyp mac_tool.py.

Add a new script to copy data into an iOS/Mac bundle based on the gyp
script (but removing extra work that is not required as it is done in
previous steps).

BUG=297668
Committed: https://crrev.com/62321627a76f6990ce912fc24fd5d1c6d0ab7c74
Cr-Commit-Position: refs/heads/master@{#392332}

[sdefresne, 2016-05-05 11:04:43]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, rsesek@chromium.org

[sdefresne, 2016-05-05 11:04:44]

rsesek: Please take a look. I did remove the conversion of .plist files to
binary as it can always be done using an extra action target.

dpranke: for OWNERS

[Robert Sesek, 2016-05-05 14:38:11]

Cool, it'd be good to not depend on gyp-mac-tool in the end.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
File build/toolchain/mac/copy_data.py (right):

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
Why not name this copy_bundle_data.py to match the tool name?

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:10: from CoreFoundation import CFDataCreate,
CFPropertyListCreateFromXMLData
Moving this import into copy_strings_file will speed up invocations for
non-.strings significantly.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:14: '''Detects the encoding used by |data| from
the Byte-Order-Mark if present.
Docstrings should use """ per PEP-8.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:51: core_data = CFDataCreate(None, data,
len(data))
naming: cfdata?

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:54: sys.exit(1)
Maybe raise instead, so you get a stack trace?

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:68: if os.path.isdir(source):
There's a TODO(thakis) about mtimes in mac_tool.py. Does that still apply?

[Dirk Pranke, 2016-05-05 16:23:14]

I defer to rsesek@ here, so lgtm when he's happy (I didn't see anything
interesting that he didn't see).

[sdefresne, 2016-05-09 07:47:37]

Thank you for the review, please take another look.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
File build/toolchain/mac/copy_data.py (right):

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
On 2016/05/05 14:38:10, Robert Sesek wrote:
> Why not name this copy_bundle_data.py to match the tool name?

Renamed (there was no other reason than lazyness for the different name).

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:10: from CoreFoundation import CFDataCreate,
CFPropertyListCreateFromXMLData
On 2016/05/05 14:38:10, Robert Sesek wrote:
> Moving this import into copy_strings_file will speed up invocations for
> non-.strings significantly.

Done.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:14: '''Detects the encoding used by |data| from
the Byte-Order-Mark if present.
On 2016/05/05 14:38:10, Robert Sesek wrote:
> Docstrings should use """ per PEP-8.

Done.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:51: core_data = CFDataCreate(None, data,
len(data))
On 2016/05/05 14:38:10, Robert Sesek wrote:
> naming: cfdata? 

Done.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:54: sys.exit(1)
On 2016/05/05 14:38:10, Robert Sesek wrote:
> Maybe raise instead, so you get a stack trace?

Done.

https://codereview.chromium.org/1946203002/diff/1/build/toolchain/mac/copy_da...
build/toolchain/mac/copy_data.py:68: if os.path.isdir(source):
On 2016/05/05 14:38:10, Robert Sesek wrote:
> There's a TODO(thakis) about mtimes in mac_tool.py. Does that still apply?

I think it still apply, copied.

[Robert Sesek, 2016-05-09 14:59:45]

LGTM

[sdefresne, 2016-05-09 15:16:29]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-05-09 15:16:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1946203002/#ps40001
(title: "Fix path to the tool in toolchain definition after renaming said tool
:-)")

[commit-bot: I haz the power, 2016-05-09 15:16:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1946203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1946203002/40001

[commit-bot: I haz the power, 2016-05-09 16:30:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-09 16:33:01]

Description was changed from

==========
[GN/iOS/Mac] Decouple copy_bundle_data from gyp mac_tool.py.

Add a new script to copy data into an iOS/Mac bundle based on the gyp
script (but removing extra work that is not required as it is done in
previous steps).

BUG=297668
==========

to

==========
[GN/iOS/Mac] Decouple copy_bundle_data from gyp mac_tool.py.

Add a new script to copy data into an iOS/Mac bundle based on the gyp
script (but removing extra work that is not required as it is done in
previous steps).

BUG=297668

Committed: https://crrev.com/62321627a76f6990ce912fc24fd5d1c6d0ab7c74
Cr-Commit-Position: refs/heads/master@{#392332}
==========

[commit-bot: I haz the power, 2016-05-09 16:33:02]

Patchset 3 (id:??) landed as
https://crrev.com/62321627a76f6990ce912fc24fd5d1c6d0ab7c74
Cr-Commit-Position: refs/heads/master@{#392332}