chrome/browser/themes/theme_syncable_service.cc - Issue 19462009: [DRAFT] Allow a user to revert to their previous theme without closing infobar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_syncable_service.cc

Issue 19462009: [DRAFT] Allow a user to revert to their previous theme without closing infobar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/themes/theme_service.cc ('K') | « chrome/browser/themes/theme_service_unittest.cc ('k') | chrome/test/data/extensions/theme_minimal/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/theme_syncable_service.cc

diff --git a/chrome/browser/themes/theme_syncable_service.cc b/chrome/browser/themes/theme_syncable_service.cc

index 3389443e055fc321051edd8da9810b22d886243e..61c656f507da59c96d25699ff2a6525777e5a578 100644

--- a/chrome/browser/themes/theme_syncable_service.cc

+++ b/chrome/browser/themes/theme_syncable_service.cc

@@ -218,12 +218,8 @@ void ThemeSyncableService::SetCurrentThemeFromThemeSpecifics(

DVLOG(1) << "Extension " << id << " is not a theme; aborting";

return;

}

- if (!extensions_service->IsExtensionEnabled(id)) {

- DVLOG(1) << "Theme " << id << " is not enabled; aborting";

- return;

- }

- // An enabled theme extension with the given id was found, so

- // just set the current theme to it.

+ // A theme extension with the given id was found, so just set the current

+ // theme to it.

theme_service_->SetTheme(extension);

} else {

// No extension with this id exists -- we must install it; we do