Issue 19462007: pull mipmap class into its own (private) header

Issue 19462007: pull mipmap class into its own (private) header (Closed)

Created:
7 years, 5 months ago by reed1

Modified:
7 years, 5 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

pull mipmap class into its own (private) header BUG= R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=10161

Patch Set 2 : #

Total comments: 3

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+338 lines, -0 lines)			Patch
M	gyp/core.gypi	View		1 chunk	+1 line, -0 lines	1 comment	Download
M	gyp/tests.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/core/SkMipMap.h	View		1 chunk	+38 lines, -0 lines	1 comment	Download
A	src/core/SkMipMap.cpp	View		1 chunk	+239 lines, -0 lines	1 comment	Download
A	tests/MipMapTest.cpp	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

scroggo

lgtm. I'll be mucking with the interface for caching purposes, but this is fine to ...

7 years, 5 months ago (2013-07-18 19:45:56 UTC) #3

reed1

Committed patchset #2 manually as r10161 (presubmit successful).

7 years, 5 months ago (2013-07-18 19:53:35 UTC) #4

tfarina

https://codereview.chromium.org/19462007/diff/3001/gyp/core.gypi File gyp/core.gypi (right): https://codereview.chromium.org/19462007/diff/3001/gyp/core.gypi#newcode110 gyp/core.gypi:110: '<(skia_src_path)/core/SkMipMap.cpp', also add: '<(skia_src_path)/core/SkMipMap.h',

7 years, 5 months ago (2013-07-18 21:01:26 UTC) #5

tfarina

7 years, 5 months ago (2013-07-18 21:02:07 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/19462007/diff/3001/src/core/SkMipMap.cpp
File src/core/SkMipMap.cpp (right):

https://codereview.chromium.org/19462007/diff/3001/src/core/SkMipMap.cpp#newc...
src/core/SkMipMap.cpp:1: #include "SkMipMap.h"
copyright missing.

https://codereview.chromium.org/19462007/diff/3001/src/core/SkMipMap.h
File src/core/SkMipMap.h (right):

https://codereview.chromium.org/19462007/diff/3001/src/core/SkMipMap.h#newcode1
src/core/SkMipMap.h:1: #ifndef SkMipMap_DEFINED
copyright

Expand Messages | Collapse Messages