Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1946163002: [Smart Lock] Make Auto-signin first run experience dialog modal. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Make Auto-signin first run experience dialog modal. BUG=609050 Committed: https://crrev.com/3f7507feb7fc4bc05bf375455f204ff10a753b0d Cr-Commit-Position: refs/heads/master@{#391473}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/password_manager/AutoSigninFirstRunDialog.java View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946163002/1
4 years, 7 months ago (2016-05-04 08:58:21 UTC) #2
melandory
PTAL.
4 years, 7 months ago (2016-05-04 08:58:26 UTC) #4
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-04 09:02:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946163002/20001
4 years, 7 months ago (2016-05-04 10:02:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 10:43:42 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 10:45:36 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3f7507feb7fc4bc05bf375455f204ff10a753b0d
Cr-Commit-Position: refs/heads/master@{#391473}

Powered by Google App Engine
This is Rietveld 408576698