Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: media/gpu/BUILD.gn

Issue 1946153002: Fix V4L2 device failed to create on veyron board (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/media_gpu.gypi » ('j') | media/media_gpu.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/BUILD.gn
diff --git a/media/gpu/BUILD.gn b/media/gpu/BUILD.gn
index 87592d7fada7e593347733bdf753972b2478cd60..6977de1d3a9fe3140dbf2c0a5e68f1b9f1444481 100644
--- a/media/gpu/BUILD.gn
+++ b/media/gpu/BUILD.gn
@@ -126,6 +126,13 @@ if (is_mac) {
}
}
+config("gpu_config") {
+ defines = []
+ if (is_chromeos && use_v4lplugin) {
+ defines += [ "USE_LIBV4L2" ]
+ }
+}
+
component("gpu") {
output_name = "media_gpu"
@@ -167,6 +174,8 @@ component("gpu") {
libs = []
ldflags = []
+ all_dependent_configs = [ ":gpu_config" ]
wuchengli 2016/05/05 14:44:05 FYI. All targets that transitively depend on the c
xhwang 2016/05/05 16:59:13 Will public_configs work for your use case? We try
kcwu 2016/05/05 17:17:12 content/common doesn't depend on media/gpu directl
+
if (is_mac) {
sources += [
"vt_mac.h",
@@ -235,7 +244,6 @@ component("gpu") {
"vp9_picture.h",
]
if (use_v4lplugin) {
- defines += [ "USE_LIBV4L2" ]
wuchengli 2016/05/05 14:44:05 FYI. all_dependent_configs applies the config to t
sources += get_target_outputs(":libv4l2_generate_stubs")
deps += [ ":libv4l2_generate_stubs" ]
}
« no previous file with comments | « no previous file | media/media_gpu.gypi » ('j') | media/media_gpu.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698