components/autofill/content/renderer/password_autofill_agent.h - Issue 1946143002: Destroy (Password)AutofillAgent safely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 1946143002: Destroy (Password)AutofillAgent safely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also setChecked Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index 39bba48da1a09245e9b8cb2416b8350ac98ea4ac..5d430e0b830ff048bab52bf2bbcce994f1e925ee 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -153,6 +153,7 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

bool is_same_page_navigation) override;

void WillSendSubmitEvent(const blink::WebFormElement& form) override;

void WillSubmitForm(const blink::WebFormElement& form) override;

+ void OnDestruct() override;

// RenderView IPC handlers:

void OnFillPasswordForm(int key, const PasswordFormFillData& form_data);