Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: components/autofill/content/renderer/autofill_agent.h

Issue 1946143002: Destroy (Password)AutofillAgent safely (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also setChecked Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/autofill_agent.h
diff --git a/components/autofill/content/renderer/autofill_agent.h b/components/autofill/content/renderer/autofill_agent.h
index fd3cbef81a9d02c2c4976db43b307c9eebdf4f8b..f22ca0c31a7c371838f8bf772a3b23006b590ede 100644
--- a/components/autofill/content/renderer/autofill_agent.h
+++ b/components/autofill/content/renderer/autofill_agent.h
@@ -73,6 +73,10 @@ class AutofillAgent : public content::RenderFrameObserver,
LegacyAutofillAgent(content::RenderView* render_view, AutofillAgent* agent);
~LegacyAutofillAgent() override;
+ // Shuts the LegacyAutofillAgent down on RenderFrame deletion. Safe to call
+ // multiple times.
+ void Shutdown();
+
private:
// content::RenderViewObserver:
void OnDestruct() override;
@@ -121,6 +125,11 @@ class AutofillAgent : public content::RenderFrameObserver,
void WillSubmitForm(const blink::WebFormElement& form) override;
void DidChangeScrollOffset() override;
void FocusedNodeChanged(const blink::WebNode& node) override;
+ void OnDestruct() override;
+
+ // Shuts the AutofillAgent down on RenderFrame deletion. Safe to call multiple
+ // times.
+ void Shutdown();
// Pass-through from LegacyAutofillAgent. This correlates with the
// RenderViewObserver method.
« no previous file with comments | « no previous file | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698