Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1946063002: Replace DeviceManager::GetDeviceChanges with a client interface. (Closed)

Created:
4 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@proper_stubs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DeviceManager::GetDeviceChanges with a client interface. Changes to the Mojo EDK mean that it is no longer necessary to prefer always calling from the browser process to render process. Thus, we can replace the awkward GetDeviceChanges method with a DeviceManagerClient interface implemented by Blink's USB object. BUG=None Committed: https://crrev.com/b5ce3314faf7fe2240f092e52d2c0a92ab5254c6 Cr-Commit-Position: refs/heads/master@{#392200}

Patch Set 1 #

Patch Set 2 : Register pre-finalizer. #

Patch Set 3 : Rebased. #

Patch Set 4 : Rebase.d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -162 lines) Patch
M device/usb/mojo/device_manager_impl.h View 2 chunks +2 lines, -9 lines 0 comments Download
M device/usb/mojo/device_manager_impl.cc View 4 chunks +10 lines, -36 lines 0 comments Download
M device/usb/mojo/device_manager_impl_unittest.cc View 7 chunks +46 lines, -56 lines 0 comments Download
M device/usb/public/interfaces/device_manager.mojom View 1 chunk +12 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 6 chunks +9 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/usb/usbDevice-iframe.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.h View 5 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 2 3 3 chunks +22 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
Reilly Grant (use Gerrit)
rockot@ please take a look. palmer@ for IPC review.
4 years, 7 months ago (2016-05-04 00:46:52 UTC) #2
haraken
The pre-finalizer part LGTM.
4 years, 7 months ago (2016-05-04 03:29:32 UTC) #3
Reilly Grant (use Gerrit)
Ping, palmer@ for an IPC review.
4 years, 7 months ago (2016-05-05 23:11:12 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-06 20:15:32 UTC) #6
palmer
lgtm
4 years, 7 months ago (2016-05-06 21:09:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946063002/60001
4 years, 7 months ago (2016-05-06 23:14:33 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-06 23:19:31 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 23:21:57 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b5ce3314faf7fe2240f092e52d2c0a92ab5254c6
Cr-Commit-Position: refs/heads/master@{#392200}

Powered by Google App Engine
This is Rietveld 408576698