device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h - Issue 1946053002: Fixes to DBus GATT components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h

Issue 1946053002: Fixes to DBus GATT components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc ('k') | device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h

diff --git a/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h b/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h

index ffa5f3c4a83091b2f0d0ecd8e6b18a80821bcf60..8e6258c7241f3c9949accea69a61dfa456a02921 100644

--- a/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h

+++ b/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_impl.h

@@ -53,13 +53,13 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothGattApplicationServiceProviderImpl

bool OnOriginThread();

template <typename Attribute>

- void WriteObjectStruct(dbus::MessageWriter* writer,

- const std::string& attribute_interface,

- Attribute* attribute);

+ void WriteObjectDict(dbus::MessageWriter* writer,

+ const std::string& attribute_interface,

+ Attribute* attribute);

template <typename Attribute>

- void WriteInterfaceStruct(dbus::MessageWriter* writer,

- const std::string& attribute_interface,

- Attribute* attribute);

+ void WriteInterfaceDict(dbus::MessageWriter* writer,

+ const std::string& attribute_interface,

+ Attribute* attribute);

void WriteAttributeProperties(

dbus::MessageWriter* writer,