Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 194603003: gin: Add the concept of named and indexed interceptors. (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

gin: Add the concept of named and indexed interceptors. This will allow for using gin as a drop-in replacement for NPObject. BUG=347565 R=abarth@chromium.org,dcarney@chromium.org,aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256431

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -0 lines) Patch
M gin/gin.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
A gin/interceptor.h View 1 1 chunk +63 lines, -0 lines 0 comments Download
A gin/interceptor.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
A gin/interceptor_unittest.cc View 1 1 chunk +159 lines, -0 lines 0 comments Download
M gin/object_template_builder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gin/object_template_builder.cc View 1 2 chunks +141 lines, -0 lines 0 comments Download
M gin/per_isolate_data.h View 1 4 chunks +26 lines, -0 lines 0 comments Download
M gin/per_isolate_data.cc View 1 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-11 14:10:49 UTC) #1
jochen (gone - plz use gerrit)
Since the interceptors require several methods with defined signatures, I didn't use template magic, but ...
6 years, 9 months ago (2014-03-11 15:37:50 UTC) #2
abarth-chromium
Neat. LGTM
6 years, 9 months ago (2014-03-11 18:33:20 UTC) #3
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 9 months ago (2014-03-11 19:28:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/194603003/20001
6 years, 9 months ago (2014-03-11 19:56:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 21:53:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-11 21:53:28 UTC) #7
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 9 months ago (2014-03-11 21:56:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/194603003/20001
6 years, 9 months ago (2014-03-11 22:35:06 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 04:59:09 UTC) #10
Message was sent while issue was closed.
Change committed as 256431

Powered by Google App Engine
This is Rietveld 408576698