scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json - Issue 1946023004: Revert of Enable hermetic builds for FYI mac builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json

Issue 1946023004: Revert of Enable hermetic builds for FYI mac builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan_tester.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json

index 07df298260bb7f39c8f5ccd42249d57106a4d31b..ec218d227f3128f1e067e5d6f413c767c8b15f5a 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json

@@ -125,7 +125,6 @@

"runhooks"

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"GYP_CHROMIUM_NO_ACTION": "1",

"GYP_DEFINES": "asan=1 clang=1 clang_use_chrome_plugins=0 component=static_library fastbuild=0 target_arch=x64 test_isolation_mode=prepare",

@@ -240,7 +239,6 @@

"/path/to/tmp/json"

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"LLVM_FORCE_HEAD_REVISION": "YES"

@@ -282,7 +280,6 @@

"all"

"env": {

- "FORCE_MAC_TOOLCHAIN": "1",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

"LLVM_FORCE_HEAD_REVISION": "YES"