Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 19460006: Merged r15723, r15724, r15725, r15728 into trunk branch. (Closed)

Created:
7 years, 5 months ago by Jakob Kummerow
Modified:
7 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Merged r15723, r15724, r15725, r15728 into trunk branch. Synchronize Compare-Literal behavior in FullCodegen and Hydrogen There is no undefined Literal. Fix LiteralCompareTypeof breakage introduced in r15723 Better fix for LiteralCompareTypeof BUG=chromium:260345 R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -107 lines) Patch
M src/ast.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ast.cc View 3 chunks +15 lines, -7 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +22 lines, -69 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-260345.js View 1 chunk +22 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
7 years, 5 months ago (2013-07-18 17:00:40 UTC) #1
Yang
On 2013/07/18 17:00:40, Jakob wrote: lgtm
7 years, 5 months ago (2013-07-18 17:01:58 UTC) #2
Jakob Kummerow
7 years, 5 months ago (2013-07-18 17:02:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698