[Findit] Fix Key_error: 'review_url' in handlers_util.py

[Findit] Fix Key_error: 'review_url' in handlers_util.py

BUG=608935
Committed: https://chromium.googlesource.com/infra/infra/+/db2cb48782bb12768d651d3c743434ada305d449

[chanli, 2016-05-03 23:33:52]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2016-05-03 23:33:53]

ptal

[stgao, 2016-05-03 23:38:28]

lgtm with nits.

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
File appengine/findit/handlers/handlers_util.py (right):

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:261:
'url',list_of_culprits[0].get('review_url', None))
style nit: "'url', list..."

Same below.

[lijeffrey, 2016-05-03 23:39:35]

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
File appengine/findit/handlers/handlers_util.py (right):

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:260: 'review_url':
list_of_culprits[0].get(
so is it possible for there to be revision and commit position but not review
url?

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:261:
'url',list_of_culprits[0].get('review_url', None))
nit: space after ,

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:273:
'url',iterate_culprit.get('review_url', None))
nit: space after ,

[chanli, 2016-05-03 23:45:20]

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
File appengine/findit/handlers/handlers_util.py (right):

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:260: 'review_url':
list_of_culprits[0].get(
On 2016/05/03 23:39:35, lijeffrey wrote:
> so is it possible for there to be revision and commit position but not review
> url?

Just in case we change the key name once again. Although theoretically it
shouldn't happen.

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:261:
'url',list_of_culprits[0].get('review_url', None))
On 2016/05/03 23:39:35, lijeffrey wrote:
> nit: space after ,

Done.

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:261:
'url',list_of_culprits[0].get('review_url', None))
On 2016/05/03 23:38:28, stgao wrote:
> style nit: "'url', list..."
> 
> Same below.

Done.

https://codereview.chromium.org/1945993002/diff/1/appengine/findit/handlers/h...
appengine/findit/handlers/handlers_util.py:273:
'url',iterate_culprit.get('review_url', None))
On 2016/05/03 23:39:35, lijeffrey wrote:
> nit: space after ,

Done.

[lijeffrey, 2016-05-03 23:55:56]

lgtm

[chanli, 2016-05-03 23:56:16]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-05-03 23:56:17]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/1945993002/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2016-05-03 23:56:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945993002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945993002/20001

[commit-bot: I haz the power, 2016-05-04 00:00:40]

Description was changed from

==========
[Findit] Fix Key_error: 'review_url' in handlers_util.py

BUG=608935
==========

to

==========
[Findit] Fix Key_error: 'review_url' in handlers_util.py

BUG=608935

Committed:
https://chromium.googlesource.com/infra/infra/+/db2cb48782bb12768d651d3c74343...
==========

[commit-bot: I haz the power, 2016-05-04 00:00:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/db2cb48782bb12768d651d3c74343...