Mojo: MultiprocessTestHelper: Allow {ASSERT,EXPECT}_...() to be used in child.

Mojo: MultiprocessTestHelper: Allow {ASSERT,EXPECT}_...() to be used in child.

Add a new macro, MOJO_MULTIPROCESS_TEST_CHILD_TEST() to define the test
body in the child process, where ASSERT_...() and EXPECT_...() can be
used as expected. Add a new method, WaitForChildTestShutdown(), to
MultiprocessTestHelper, which returns true if everything passed in the
child. (Keep the old macro and old WaitForChildShutdown() around, since
sometimes we want to use the child's exit code to report other
information.)

R=yzshen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256373

[yzshen1, 2014-03-11 22:59:58]

LGTM with one question

https://codereview.chromium.org/194593007/diff/1/mojo/common/test/multiproces...
File mojo/common/test/multiprocess_test_helper.h (right):

https://codereview.chromium.org/194593007/diff/1/mojo/common/test/multiproces...
mojo/common/test/multiprocess_test_helper.h:45: //
|EXPECT_TRUE(WaitForChildShutdown());|. Mainly for use with FIXME
I haven't understood. If WaitForChildShutdown() is preferred, and it is quite
easy to use, why do we need to introduce this new method?

[viettrungluu, 2014-03-11 23:33:14]

Thanks.

https://codereview.chromium.org/194593007/diff/1/mojo/common/test/multiproces...
File mojo/common/test/multiprocess_test_helper.h (right):

https://codereview.chromium.org/194593007/diff/1/mojo/common/test/multiproces...
mojo/common/test/multiprocess_test_helper.h:45: //
|EXPECT_TRUE(WaitForChildShutdown());|. Mainly for use with FIXME
On 2014/03/11 22:59:58, yzshen1 wrote:
> I haven't understood. If WaitForChildShutdown() is preferred, and it is quite
> easy to use, why do we need to introduce this new method?

WaitForChildShutdown() isn't preferred.

FIXME = MOJO_MULTIPROCESS_TEST_CHILD_TEST().

And it should be |EXPECT_TRUE(WaitForChildTestShutdown());|.

Oops!

[viettrungluu, 2014-03-12 00:50:14]

Committed patchset #2 manually as r256373 (presubmit successful).