Source/core/html/HTMLTableColElement.cpp - Issue 194593005: ASSERTION FAILED: span >= 1 in WebCore::RenderTable::slowColElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTableColElement.cpp

Issue 194593005: ASSERTION FAILED: span >= 1 in WebCore::RenderTable::slowColElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTableColElement.cpp

diff --git a/Source/core/html/HTMLTableColElement.cpp b/Source/core/html/HTMLTableColElement.cpp

index 19e301d95c045add824696d4600acab78d74193a..0bae57e51fc42772028dfd58be8e835a3271641d 100644

--- a/Source/core/html/HTMLTableColElement.cpp

+++ b/Source/core/html/HTMLTableColElement.cpp

@@ -64,7 +64,8 @@ void HTMLTableColElement::collectStyleForPresentationAttribute(const QualifiedNa

void HTMLTableColElement::parseAttribute(const QualifiedName& name, const AtomicString& value)

{

if (name == spanAttr) {

- m_span = !value.isNull() ? value.toInt() : 1;

+ int newSpan = value.toInt();

kenneth.r.christiansen 2014/03/11 13:59:16 I would add a comment here // Use 1 if number is

+ m_span = newSpan ? newSpan : 1;

if (renderer() && renderer()->isRenderTableCol())

renderer()->updateFromElement();

} else if (name == widthAttr) {

« no previous file with comments | « LayoutTests/fast/table/incorrect-colgroup-span-values-expected.txt ('k') | no next file » | no next file with comments »