LayoutTests/fast/table/incorrect-colgroup-span-values.html - Issue 194593005: ASSERTION FAILED: span >= 1 in WebCore::RenderTable::slowColElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/incorrect-colgroup-span-values.html

Issue 194593005: ASSERTION FAILED: span >= 1 in WebCore::RenderTable::slowColElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 if (window.testRunner)

	6 testRunner.dumpAsText();

	7

	8 function removeSpan() {

	9 document.getElementById("colGroup").removeAttribute("span");

	10 }

	11 </script>

	12 </head>

	13 <body onload="removeSpan()">

	14 <p>This test passes if it does not crash.</p>
	Julien - ping for review 2014/03/13 18:29:24 Let's add a description to this test: <p>This tes Let's add a description to this test: <p>This test checks that invalid 'span' values are rejected.</p>
	15 <table>

	16 <colgroup id="colGroup" span="10000000000">

	17 <th></th>

	18 </colgroup>

	19 </table>

	20 <table>

	21 <colgroup span="0">

	22 <th></th>

	23 </colgroup>

	24 </table>

	25 <table>

	26 <colgroup span="10000000000">

	27 <th></th>

	28 </colgroup>

	29 </table>

	30 <table>

	31 <colgroup span="-10000000000">

	32 <th></th>

	33 </colgroup>

	34 </table>
	Julien - ping for review 2014/03/13 18:29:24 Missing from the testing: - colgroup span="cheese Missing from the testing: - colgroup span="cheese" (or whatever invalid value you fancy!) - col span="..." - Super important! Check that the returned value of getAttribute("span") is 1 as expected (ie we rejected the value)
	35 </body>

	36 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/table/incorrect-colgroup-span-values-expected.txt » ('j') | Source/core/html/HTMLTableColElement.cpp » ('J')