Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1945913002: Revert of 🎯 Fail if an instrumentation test is missing size annotation (Closed)

Created:
4 years, 7 months ago by Mathieu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, kjellander_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🎯 Fail if an instrumentation test is missing size annotation (patchset #6 id:100001 of https://codereview.chromium.org/1863353002/ ) Reason for revert: One of the touched tests failed on the bots https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/26168 Original issue's description: > Fail if an instrumentation test is missing size annotation > > Right now we just silently never run such tests. > > BUG=601464 > > Committed: https://crrev.com/70d776ed260e4c48a4f4a92903030f1e578ef291 > Cr-Commit-Position: refs/heads/master@{#391288} TBR=jbudorick@chromium.org,sgurun@chromium.org,yfriedman@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601464 Committed: https://crrev.com/e682757ee4379efa1b1e23fd07d7541248fd12ff Cr-Commit-Position: refs/heads/master@{#391343}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Mathieu
Created Revert of 🎯 Fail if an instrumentation test is missing size annotation
4 years, 7 months ago (2016-05-03 20:25:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945913002/1
4 years, 7 months ago (2016-05-03 20:25:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 20:26:08 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e682757ee4379efa1b1e23fd07d7541248fd12ff Cr-Commit-Position: refs/heads/master@{#391343}
4 years, 7 months ago (2016-05-03 20:27:49 UTC) #6
agrieve
4 years, 7 months ago (2016-05-04 00:29:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1950793002/ by agrieve@chromium.org.

The reason for reverting is: Will disable failing test..

Powered by Google App Engine
This is Rietveld 408576698