services/media/factory_service/media_decoder_impl.h - Issue 1945903006: Motown: Move responsibility for binding to MediaFactoryService::Product

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/factory_service/media_decoder_impl.h

Issue 1945903006: Motown: Move responsibility for binding to MediaFactoryService::Product (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« services/media/factory_service/factory_service.h ('K') | « services/media/factory_service/factory_service.cc ('k') | services/media/factory_service/media_decoder_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/media/factory_service/media_decoder_impl.h

diff --git a/services/media/factory_service/media_decoder_impl.h b/services/media/factory_service/media_decoder_impl.h

index 637d0f7375f60fbb7a1ace99b8d4a3e963b7ca06..913169eb9ac19c5d4b90580a32e22d56d0842139 100644

--- a/services/media/factory_service/media_decoder_impl.h

+++ b/services/media/factory_service/media_decoder_impl.h

@@ -19,8 +19,9 @@ namespace mojo {

namespace media {

// Mojo agent that decodes a stream.

-class MediaDecoderImpl : public MediaFactoryService::Product,

- public MediaTypeConverter {

+class MediaDecoderImpl

+ : public MediaFactoryService::Product<MediaTypeConverter>,

+ public MediaTypeConverter {

public:

static std::shared_ptr<MediaDecoderImpl> Create(

MediaTypePtr input_media_type,

@@ -41,7 +42,6 @@ class MediaDecoderImpl : public MediaFactoryService::Product,

InterfaceRequest<MediaTypeConverter> request,

MediaFactoryService* owner);

- Binding<MediaTypeConverter> binding_;

Graph graph_;

std::shared_ptr<MojoConsumer> consumer_;

std::shared_ptr<Decoder> decoder_;