Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945903004: Add show-all feature to the all-flake-occurrences page (Closed)

Created:
4 years, 7 months ago by Sergiy Byelozyorov
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@deprecate_bug_friendly
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Fix #

Patch Set 4 : Fix #

Total comments: 4

Patch Set 5 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M appengine/chromium_try_flakes/handlers/all_flake_occurrences.py View 1 2 3 4 4 chunks +9 lines, -7 lines 0 comments Download
M appengine/chromium_try_flakes/templates/all_flake_occurrences.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M appengine/chromium_try_flakes/templates/index.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Sergiy Byelozyorov
4 years, 7 months ago (2016-05-04 16:11:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945903004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945903004/20001
4 years, 7 months ago (2016-05-04 16:16:09 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 16:22:39 UTC) #5
shishkander
LGTM % comment https://codereview.chromium.org/1945903004/diff/60001/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py File appengine/chromium_try_flakes/handlers/all_flake_occurrences.py (right): https://codereview.chromium.org/1945903004/diff/60001/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py#newcode17 appengine/chromium_try_flakes/handlers/all_flake_occurrences.py:17: MAX_OCCURRENCES_WITHOUT_SHOW_ALL = 50 suggestion: MAX_OCCURRENCES_BY_DEFAULT = ...
4 years, 7 months ago (2016-05-06 21:41:10 UTC) #8
Sergiy Byelozyorov
https://codereview.chromium.org/1945903004/diff/60001/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py File appengine/chromium_try_flakes/handlers/all_flake_occurrences.py (right): https://codereview.chromium.org/1945903004/diff/60001/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py#newcode17 appengine/chromium_try_flakes/handlers/all_flake_occurrences.py:17: MAX_OCCURRENCES_WITHOUT_SHOW_ALL = 50 On 2016/05/06 21:41:09, shishkander wrote: > ...
4 years, 7 months ago (2016-05-06 21:55:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945903004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945903004/80001
4 years, 7 months ago (2016-05-06 22:10:27 UTC) #12
Sergiy Byelozyorov
On 2016/05/06 21:41:10, shishkander wrote: > LGTM % comment > > https://codereview.chromium.org/1945903004/diff/60001/appengine/chromium_try_flakes/handlers/all_flake_occurrences.py > File appengine/chromium_try_flakes/handlers/all_flake_occurrences.py ...
4 years, 7 months ago (2016-05-06 22:11:57 UTC) #13
tandrii(chromium)
LGTM
4 years, 7 months ago (2016-05-06 22:13:37 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 22:14:28 UTC) #16
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/6d18c44be838199afd5224206c279...

Powered by Google App Engine
This is Rietveld 408576698