Move display_finder to ui/display

Move display_finder to ui/display

BUG=597761
TBR=sadrul@chromium.org

Committed: https://crrev.com/8775d3f88285089b6999f6e9ca2b7a7e2e4dc4cf
Cr-Commit-Position: refs/heads/master@{#392392}

[oshima, 2016-05-03 20:16:30]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 20:16:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945903002/1

[oshima, 2016-05-03 20:36:32]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 20:36:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945903002/20001

[commit-bot: I haz the power, 2016-05-03 20:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 20:44:22]

Dry run: Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[oshima, 2016-05-03 21:11:59]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-05-03 21:12:11]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-05-03 21:12:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945903002/40001

[commit-bot: I haz the power, 2016-05-03 21:56:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-03 21:56:42]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[oshima, 2016-05-03 23:34:02]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-03 23:34:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945903002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945903002/60001

[oshima, 2016-05-04 00:23:55]

Patchset #2 (id:40001) has been deleted

[oshima, 2016-05-04 00:24:00]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-05-04 00:33:13]

oshima@chromium.org changed reviewers:
+ robliao@chromium.org

[oshima, 2016-05-04 01:04:20]

Patchset #3 (id:100001) has been deleted

[oshima, 2016-05-04 01:04:45]

Patchset #2 (id:80001) has been deleted

[robliao, 2016-05-04 17:21:50]

https://codereview.chromium.org/1945903002/diff/60001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/1945903002/diff/60001/ui/display/BUILD.gn#new...
ui/display/BUILD.gn:176: ":test_support",
Remove this line since it's included in the main deps.

https://codereview.chromium.org/1945903002/diff/60001/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/1945903002/diff/60001/ui/gfx/gfx.gyp#newcode127
ui/gfx/gfx.gyp:127: "win/physical_size.cc",
Stray change?

[oshima, 2016-05-05 18:31:02]

https://codereview.chromium.org/1945903002/diff/60001/ui/display/BUILD.gn
File ui/display/BUILD.gn (right):

https://codereview.chromium.org/1945903002/diff/60001/ui/display/BUILD.gn#new...
ui/display/BUILD.gn:176: ":test_support",
On 2016/05/04 17:21:50, robliao - OOO until 5-11 wrote:
> Remove this line since it's included in the main deps.

Done.

https://codereview.chromium.org/1945903002/diff/60001/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/1945903002/diff/60001/ui/gfx/gfx.gyp#newcode127
ui/gfx/gfx.gyp:127: "win/physical_size.cc",
On 2016/05/04 17:21:50, robliao - OOO until 5-11 wrote:
> Stray change?

Hmm, i don't know how/who moved this. Reverted.

[oshima, 2016-05-07 01:26:51]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-07 01:27:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945903002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945903002/140001

[commit-bot: I haz the power, 2016-05-07 02:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-07 02:30:24]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-05-09 17:01:07]

oshima@chromium.org changed reviewers:
+ derat@chromium.org

[oshima, 2016-05-09 17:01:08]

Rob is ooo. Dan, can you take a look?

[Daniel Erat, 2016-05-09 17:42:21]

not your fault, but display_finder.cc seems like it should have unit tests.

https://codereview.chromium.org/1945903002/diff/140001/ui/display/display_fin...
File ui/display/display_finder.h (right):

https://codereview.chromium.org/1945903002/diff/140001/ui/display/display_fin...
ui/display/display_finder.h:19: using Display = gfx::Display;
i have a preference for avoiding using directives in header files, since
whoever's doing the #include may not actually want the symbol. mind qualifying
Display here and moving this directive to the .cc file?

[oshima, 2016-05-09 17:56:54]

https://codereview.chromium.org/1945903002/diff/140001/ui/display/display_fin...
File ui/display/display_finder.h (right):

https://codereview.chromium.org/1945903002/diff/140001/ui/display/display_fin...
ui/display/display_finder.h:19: using Display = gfx::Display;
On 2016/05/09 17:42:20, Daniel Erat wrote:
> i have a preference for avoiding using directives in header files, since
> whoever's doing the #include may not actually want the symbol. mind qualifying
> Display here and moving this directive to the .cc file?

This is necessary to convert the client of this header to use display::Display,
and temporary. It will be removed in next CL
(https://codereview.chromium.org/1953223002/)

[Daniel Erat, 2016-05-09 17:58:12]

lgtm

thanks, i was hoping that was going to happen soon in a followup change. :-)

[oshima, 2016-05-09 18:17:52]

Description was changed from

==========
Move display_finder to ui/display

BUG=597761
==========

to

==========
Move display_finder to ui/display

BUG=597761
TBR=sadrul@chromium.org
==========

[oshima, 2016-05-09 18:18:06]

oshima@chromium.org changed reviewers:
+ sadrul@chromium.org

[oshima, 2016-05-09 18:18:07]

tbr'ing sadrul for trivial change in ui/views/mus

[oshima, 2016-05-09 18:18:14]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-05-09 18:18:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1945903002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1945903002/140001

[commit-bot: I haz the power, 2016-05-09 19:24:35]

Description was changed from

==========
Move display_finder to ui/display

BUG=597761
TBR=sadrul@chromium.org
==========

to

==========
Move display_finder to ui/display

BUG=597761
TBR=sadrul@chromium.org
==========

[commit-bot: I haz the power, 2016-05-09 19:24:36]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-05-09 19:25:51]

Description was changed from

==========
Move display_finder to ui/display

BUG=597761
TBR=sadrul@chromium.org
==========

to

==========
Move display_finder to ui/display

BUG=597761
TBR=sadrul@chromium.org

Committed: https://crrev.com/8775d3f88285089b6999f6e9ca2b7a7e2e4dc4cf
Cr-Commit-Position: refs/heads/master@{#392392}
==========

[commit-bot: I haz the power, 2016-05-09 19:25:52]

Patchset 3 (id:??) landed as
https://crrev.com/8775d3f88285089b6999f6e9ca2b7a7e2e4dc4cf
Cr-Commit-Position: refs/heads/master@{#392392}