Issue 19459002: rebaseline.py: re-record already succeeding test results, just in case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19459002: rebaseline.py: re-record already succeeding test results, just in case (Closed)

Created:
7 years, 5 months ago by epoger

Modified:
7 years, 5 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

rebaseline.py: re-record already succeeding test results, just in case TBR=borenet Committed: https://code.google.com/p/skia/source/detail?r=10121

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tools/rebaseline.py	View		1 chunk	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

epoger

Committed patchset #1 manually as r10121 (presubmit successful).

7 years, 5 months ago (2013-07-17 00:09:13 UTC) #1

epoger

Sorry for all the TBR commits today. I'm just trying to get everything in shape ...

7 years, 5 months ago (2013-07-17 00:10:15 UTC) #2

borenet

https://codereview.chromium.org/19459002/diff/1/tools/rebaseline.py File tools/rebaseline.py (right): https://codereview.chromium.org/19459002/diff/1/tools/rebaseline.py#newcode223 tools/rebaseline.py:223: gm_json.JSONKEY_ACTUALRESULTS_SUCCEEDED] I'm confused - this enables comparison between the ...

7 years, 5 months ago (2013-07-17 13:21:23 UTC) #3

LGTM per our live discussion

Expand Messages | Collapse Messages