Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1945883002: Remove SkFontHost.h. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkFontHost.h. What is left of this file is now in SkFontLCDConfig.h. Committed: https://skia.googlesource.com/skia/+/f077324e1317fe2825c8a7969bf159b4efed2ba5

Patch Set 1 #

Patch Set 2 : Rename to reduce future confusion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -166 lines) Patch
M gyp/core.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
D include/core/SkFontHost.h View 1 chunk +0 lines, -95 lines 0 comments Download
M src/core/SkFontHost.cpp View 1 1 chunk +0 lines, -48 lines 0 comments Download
A + src/core/SkFontLCDConfig.cpp View 1 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945883002/1
4 years, 7 months ago (2016-05-03 19:51:20 UTC) #4
bungeman-skia
4 years, 7 months ago (2016-05-03 19:55:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945883002/20001
4 years, 7 months ago (2016-05-03 20:02:43 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 20:18:47 UTC) #13
reed1
lgtm
4 years, 7 months ago (2016-05-03 20:57:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945883002/20001
4 years, 7 months ago (2016-05-10 21:10:52 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 21:32:11 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f077324e1317fe2825c8a7969bf159b4efed2ba5

Powered by Google App Engine
This is Rietveld 408576698