Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1945833002:
[libfuzzer] Use max_len=803500 for convert_woff2ttf_fuzzer. (Closed)
Description[libfuzzer] Use max_len=803500 for convert_woff2ttf_fuzzer.
TBR=aizatsky@chromium.org, ochang@chromium.org
BUG=608803
Committed: https://crrev.com/24d84013dd7d07c2a0fd72c755a841d7e77ddd2f
Cr-Commit-Position: refs/heads/master@{#391325}
Patch Set 1 #Patch Set 2 : Set max_len a bit higher than size of biggest seed corpus file. #Messages
Total messages: 19 (8 generated)
On 2016/05/03 18:04:52, mmoroz wrote: Value of 60000 has been suggested by kcc@. I set TBR and land this.
Description was changed from ========== [libfuzzer] Use max_len=60000 for convert_woff2ttf_fuzzer. R=aizatsky@chromium.org, ochang@chromium.org BUG=608803 ========== to ========== [libfuzzer] Use max_len=60000 for convert_woff2ttf_fuzzer. TBR=aizatsky@chromium.org, ochang@chromium.org BUG=608803 ==========
The CQ bit was checked by mmoroz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945833002/1
lgtm
Seed corpus is much bigger than this. I think the biggest one is 800k.
On 2016/05/03 18:08:38, aizatsky wrote: > Seed corpus is much bigger than this. I think the biggest one is 800k. That's true. Do you think it is fine to use max_len value of 800k? 7 of 10 seed corpus files are smaller than 60k. I would prefer to find more small .woff files and upload them into GCS bucket or into the repo.
On 2016/05/03 18:13:22, mmoroz wrote: > On 2016/05/03 18:08:38, aizatsky wrote: > > Seed corpus is much bigger than this. I think the biggest one is 800k. > > That's true. Do you think it is fine to use max_len value of 800k? 7 of 10 seed > corpus files are smaller than 60k. I would prefer to find more small .woff files > and upload them into GCS bucket or into the repo. Licensing could be an issue. I suggest we let it run and see how big items in the corpus get. We may be able to remove too big .woff files later from the seed.
The CQ bit was unchecked by mmoroz@chromium.org
Description was changed from ========== [libfuzzer] Use max_len=60000 for convert_woff2ttf_fuzzer. TBR=aizatsky@chromium.org, ochang@chromium.org BUG=608803 ========== to ========== [libfuzzer] Use max_len=803500 for convert_woff2ttf_fuzzer. TBR=aizatsky@chromium.org, ochang@chromium.org BUG=608803 ==========
On 2016/05/03 18:16:21, aizatsky wrote: > On 2016/05/03 18:13:22, mmoroz wrote: > > On 2016/05/03 18:08:38, aizatsky wrote: > > > Seed corpus is much bigger than this. I think the biggest one is 800k. > > > > That's true. Do you think it is fine to use max_len value of 800k? 7 of 10 > seed > > corpus files are smaller than 60k. I would prefer to find more small .woff > files > > and upload them into GCS bucket or into the repo. > > Licensing could be an issue. I suggest we let it run and see how big items in > the corpus get. > We may be able to remove too big .woff files later from the seed. Agreed. Set 803500 (the biggest seed corpus file is 803300).
The CQ bit was checked by mmoroz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org Link to the patchset: https://codereview.chromium.org/1945833002/#ps20001 (title: "Set max_len a bit higher than size of biggest seed corpus file.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945833002/20001
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Use max_len=803500 for convert_woff2ttf_fuzzer. TBR=aizatsky@chromium.org, ochang@chromium.org BUG=608803 ========== to ========== [libfuzzer] Use max_len=803500 for convert_woff2ttf_fuzzer. TBR=aizatsky@chromium.org, ochang@chromium.org BUG=608803 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [libfuzzer] Use max_len=803500 for convert_woff2ttf_fuzzer. TBR=aizatsky@chromium.org, ochang@chromium.org BUG=608803 ========== to ========== [libfuzzer] Use max_len=803500 for convert_woff2ttf_fuzzer. TBR=aizatsky@chromium.org, ochang@chromium.org BUG=608803 Committed: https://crrev.com/24d84013dd7d07c2a0fd72c755a841d7e77ddd2f Cr-Commit-Position: refs/heads/master@{#391325} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/24d84013dd7d07c2a0fd72c755a841d7e77ddd2f Cr-Commit-Position: refs/heads/master@{#391325} |
