third_party/WebKit/LayoutTests/inspector/tracing/layer-tree.html - Issue 1945813002: cc: Make LayerTreeImpl dump layer list to FrameViewer and Devtools

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/tracing/layer-tree.html

Issue 1945813002: cc: Make LayerTreeImpl dump layer list to FrameViewer and Devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Force drawsContent for layout test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector/layers-test.js ('k') | third_party/WebKit/LayoutTests/inspector/tracing/layer-tree-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../http/tests/inspector/timeline-test.js"></script>	4 <script src="../../http/tests/inspector/timeline-test.js"></script>

5 <script src="../../http/tests/inspector/layers-test.js"></script>	5 <script src="../../http/tests/inspector/layers-test.js"></script>

6 <script src="../tracing-test.js"></script>	6 <script src="../tracing-test.js"></script>

7	7

8 <script>	8 <script>

9 function doActions(callback)	9 function doActions(callback)

10 {	10 {

(...skipping 26 matching lines...) Expand all Loading...
37 InspectorTest.layerTreeModel().setLayerTree(layerTree);	37 InspectorTest.layerTreeModel().setLayerTree(layerTree);

38 InspectorTest.dumpLayerTree();	38 InspectorTest.dumpLayerTree();

39 InspectorTest.completeTest();	39 InspectorTest.completeTest();

40 }	40 }

41 }	41 }

42 </script>	42 </script>

43	43

44 <body onload="runTestAfterDisplay()">	44 <body onload="runTestAfterDisplay()">

45 Tests that LayerTreeModel successfully imports layers from a trace.	45 Tests that LayerTreeModel successfully imports layers from a trace.

46 </p>	46 </p>

47 <div id="a" style="width: 200px; height: 200px" class="layer">	47 <div id="a" style="width: 200px; height: 200px; background-color: yellow" class= "layer">
	vmpstr 2016/05/31 22:16:16 Why these changes? Why these changes? sunxd 2016/05/31 22:41:52 When cc composites layers, it composites several l Show quoted text On 2016/05/31 22:16:16, vmpstr wrote: > Why these changes? When cc composites layers, it composites several layers besides these divs. The cc::LayerTreeImpl is organized in this way: +root +--composited layers (inner/outer viewport layer, page scale layer etc.) +----document (contentRoot) +------div a +--------div b1 +--------div b2 +----------div c +--------div b3 The TracingLayerTree in LayerTreeModel.js makes the first layer that draws content to be "ContentRoot". The function dumpLayerTree (called in line 38) dumps the sub layer tree from "ContentRoot" instead of the actual root. So previously, the expected result is: +----document (contentRoot) +------div a +--------div b1 +--------div b2 +----------div c +--------div b3 But now we get a bunch of internal layers (because we make every other layer a child of "ContentRoot", this approach does not affect the actual use of devtools except we don't get indents indicating tree hierarchy). I was considering making dumpLayerTree only dump layers that draw content, so I need to set the background color here. However, in another test, "layer-tree-model.html", dumpLayerTree is supposed to also dump internal layers, so I'm still thinking about solutions: adding an option to dump drawsContent layers or simply dumping every layer we composite.
48 <div class="layer" id="b1" style="width: 150px; height: 100px"></div>	48 <div class="layer" id="b1" style="width: 150px; height: 100px; background-co lor: red"></div>

49 <div id="b2" class="layer" style="width: 140px; height: 110px">	49 <div id="b2" class="layer" style="width: 140px; height: 110px; background-co lor: blue">

50 <div id="c" class="layer" style="width: 100px; height: 90px"></div>	50 <div id="c" class="layer" style="width: 100px; height: 90px; background- color: black"></div>

51 </div>	51 </div>

52 <div id="b3" class="layer" style="width: 140px; height: 110px"></div>	52 <div id="b3" class="layer" style="width: 140px; height: 110px; background-co lor: red"></div>

53 </div>	53 </div>

54 </body>	54 </body>

55 </html>	55 </html>

OLD	NEW