SyzyASAN: Export experiment state to finch synthetic field trials.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <set>
@@ skipping 1206 matching lines @@
 #endif  // BUILDFLAG(ANDROID_JAVA_UI)
 
   LaunchDevToolsHandlerIfNeeded(parsed_command_line());
   if (parsed_command_line().HasSwitch(::switches::kAutoOpenDevToolsForTabs))
     g_browser_process->CreateDevToolsAutoOpener();
 
   for (size_t i = 0; i < chrome_extra_parts_.size(); ++i)
     chrome_extra_parts_[i]->PostProfileInit();
 }
 
+namespace {
+
+#if defined(SYZYASAN)
+void WINAPI SyzyASANExperimentCallback(const char* name, const char* group) {
+  ChromeMetricsServiceAccessor::RegisterSyntheticFieldTrial(name, status);
+}
+
+void SetupSyzyASAN() {
+  typedef VOID(WINAPI* SyzyASANExperimentCallbackFn(const char* name,
+                                                    const char* group));
+  typedef VOID(WINAPI* SyzyasanEnumFeaturesFn)(SyzyASANExperimentCallbackFn);

[chrisha, 2016/05/03 20:56:36]

SyzyASAN, for consistency?

[Sigurður Ásgeirsson, 2016/05/04 13:10:45]

Done.

+  // Export the SyzyASAN experiements as synthetic field trials.

[chrisha, 2016/05/03 20:56:36]

experiments*

[Sigurður Ásgeirsson, 2016/05/04 13:10:46]

Done.

+  HMODULE syzyasan_handle = ::GetModuleHandle(L"syzyasan_rtl.dll");
+  if (!syzyasan_handle)
+    return;
+
+  SyzyasanEnumFeaturesFn syzyasan_enum_features =
+      reinterpret_cast<SyzyasanEnumFeaturesFn>(
+            ::GetProcAddress("asan_EnumFeatures"));
+  if (syzyasan_enum_features) {
+    syzyasan_enum_features(&SyzyASANExperimentCallback);
+  }
+
+  // Enable the deferred free mechanism in the syzyasan module, which helps the
+  // performance by deferring some work on the critical path to a background
+  // thread.
+  if (base::FeatureList::IsEnabled(features::kSyzyasanDeferredFree)) {
+    typedef VOID(WINAPI * SyzyasanEnableDeferredFreeThreadFunc)(VOID);
+    bool success = false;
+    SyzyasanEnableDeferredFreeThreadFunc syzyasan_enable_deferred_free =
+        reinterpret_cast<SyzyasanEnableDeferredFreeThreadFunc>(
+            ::GetProcAddress(syzyasan_handle,
+                             "asan_EnableDeferredFreeThread"));
+    if (syzyasan_enable_deferred_free) {
+      syzyasan_enable_deferred_free();
+      success = true;
+    }
+    UMA_HISTOGRAM_BOOLEAN("Syzyasan.DeferredFreeWasEnabled", success);
+  }
+

[chrisha, 2016/05/03 20:56:36]

ubernit: Remove this blank line?

[Sigurður Ásgeirsson, 2016/05/04 13:10:45]

Done.

+}
+#endif  // SYZYASAN
+
+}  // namespace
+
 void ChromeBrowserMainParts::PreBrowserStart() {
   TRACE_EVENT0("startup", "ChromeBrowserMainParts::PreBrowserStart");
   for (size_t i = 0; i < chrome_extra_parts_.size(); ++i)
     chrome_extra_parts_[i]->PreBrowserStart();
 
   three_d_observer_.reset(new ThreeDAPIObserver());
 
 #if defined(SYZYASAN)
-  // Enable the deferred free mechanism in the syzyasan module, which helps the
-  // performance by deferring some work on the critical path to a background
-  // thread.
-  if (base::FeatureList::IsEnabled(features::kSyzyasanDeferredFree)) {
-    typedef VOID(WINAPI * SyzyasanEnableDeferredFreeThreadFunc)(VOID);
-    HMODULE syzyasan_handle = ::GetModuleHandle(L"syzyasan_rtl.dll");
-    bool success = false;
-    if (syzyasan_handle) {
-      SyzyasanEnableDeferredFreeThreadFunc syzyasan_enable_deferred_free =
-          reinterpret_cast<SyzyasanEnableDeferredFreeThreadFunc>(
-              ::GetProcAddress(syzyasan_handle,
-                               "asan_EnableDeferredFreeThread"));
-      if (syzyasan_enable_deferred_free) {
-        syzyasan_enable_deferred_free();
-        success = true;
-      }
-    }
-    UMA_HISTOGRAM_BOOLEAN("Syzyasan.DeferredFreeWasEnabled", success);
-  }
+  SetupSyzyASAN();
 #endif
 
 // Start the tab manager here so that we give the most amount of time for the
 // other services to start up before we start adjusting the oom priority.
 #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
   g_browser_process->GetTabManager()->Start();
 #endif
 }
 
 void ChromeBrowserMainParts::PostBrowserStart() {
@@ skipping 688 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif  // defined(OS_CHROMEOS)
 #endif  // defined(OS_ANDROID)
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }