Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1945793002: Suppress extra cast (Closed)

Created:
4 years, 7 months ago by vsm
Modified:
4 years, 7 months ago
Reviewers:
sra1
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Suppress extra cast If I rebuild the SDK, I see a cast from List to List<E> on the next line without this. With the change, we just infer List<E> in the first place. R=sra@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/4563d879c6b70f2e463d42242a8194e99d54355a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tool/input_sdk/patch/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
4 years, 7 months ago (2016-05-03 17:26:28 UTC) #2
sra1
lgtm
4 years, 7 months ago (2016-05-03 17:28:25 UTC) #3
vsm
4 years, 7 months ago (2016-05-03 17:30:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4563d879c6b70f2e463d42242a8194e99d54355a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698