content/browser/background_sync/background_sync_manager.cc - Issue 1945753002: Make Service Worker DB UserData methods accept multiple keys at once

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.cc

Issue 1945753002: Make Service Worker DB UserData methods accept multiple keys at once (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid6encrypt

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/push_messaging/push_messaging_message_filter.h » ('j') | content/browser/push_messaging/push_messaging_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.cc

diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc

index f2b6de7fe67e8ad9ffe093b6e12ba3e09133b099..91499c2e1da46057bef1be3236ed7f2d63ab660c 100644

--- a/content/browser/background_sync/background_sync_manager.cc

+++ b/content/browser/background_sync/background_sync_manager.cc

@@ -575,7 +575,7 @@ void BackgroundSyncManager::DisableAndClearDidGetRegistrations(

for (const auto& sw_id_and_regs : user_data) {

service_worker_context_->ClearRegistrationUserData(

- sw_id_and_regs.first, kBackgroundSyncUserDataKey,

+ sw_id_and_regs.first, {kBackgroundSyncUserDataKey},

base::Bind(&BackgroundSyncManager::DisableAndClearManagerClearedOne,

weak_ptr_factory_.GetWeakPtr(), barrier_closure));

}

@@ -722,7 +722,7 @@ void BackgroundSyncManager::StoreDataInBackend(

DCHECK_CURRENTLY_ON(BrowserThread::IO);

service_worker_context_->StoreRegistrationUserData(

- sw_registration_id, origin, backend_key, data, callback);

+ sw_registration_id, origin, {{backend_key, data}}, callback);

}

void BackgroundSyncManager::GetDataFromBackend(