Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1945743003: Added a views::test::TestInkDropAnimationObserverHelper (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Added a views::test::TestInkDropAnimationObserverHelper This change is a foundation for a follow-up CL that will be adding an InkDropHoverObserver and a TestInkDropHoverObserver. This change will allow code re-use between the InkDropHoverObserver/InkDropAnimationObserver and TestInkDropHoverObserver/TestInkDropAnimationObserver classes. BUG=604415 Review URL: https://codereview.chromium.org/1896953003 Cr-Commit-Position: refs/heads/master@{#388923} (cherry picked from commit 0cf6c96f36bd9a5a6bbfebb13285d5166f193881) Committed: https://chromium.googlesource.com/chromium/src/+/320158c73cd21e96d4ddd85ca18776505e766708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -201 lines) Patch
M ui/views/animation/ink_drop_animation.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/animation/ink_drop_animation_controller_impl.cc View 1 chunk +4 lines, -5 lines 0 comments Download
A ui/views/animation/ink_drop_animation_ended_reason.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/views/animation/ink_drop_animation_ended_reason.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_animation_observer.h View 2 chunks +12 lines, -27 lines 0 comments Download
D ui/views/animation/ink_drop_animation_observer.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/views/animation/ink_drop_animation_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_animation_observer.h View 5 chunks +11 lines, -73 lines 0 comments Download
M ui/views/animation/test/test_ink_drop_animation_observer.cc View 1 chunk +5 lines, -51 lines 0 comments Download
A ui/views/animation/test/test_ink_drop_animation_observer_helper.h View 1 chunk +143 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
4 years, 7 months ago (2016-05-03 19:19:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
320158c73cd21e96d4ddd85ca18776505e766708.

Powered by Google App Engine
This is Rietveld 408576698