Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: Source/bindings/v8/V8Binding.cpp

Issue 19457002: Make 'any'-typed attributes of events available in isolated worlds (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Respond to review Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/custom/V8CustomEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Binding.cpp
diff --git a/Source/bindings/v8/V8Binding.cpp b/Source/bindings/v8/V8Binding.cpp
index c16f74ae3245c2764ed5ea45f4731a9eff974060..998c8508c81e787527c338160e8df03b60bdeedf 100644
--- a/Source/bindings/v8/V8Binding.cpp
+++ b/Source/bindings/v8/V8Binding.cpp
@@ -539,8 +539,14 @@ DOMWrapperWorld* isolatedWorldForIsolate(v8::Isolate* isolate)
return 0;
if (!DOMWrapperWorld::isolatedWorldsExist())
return 0;
- ASSERT(!v8::Context::GetEntered().IsEmpty());
- return DOMWrapperWorld::isolatedWorld(v8::Context::GetEntered());
+ ASSERT(v8::Context::InContext());
+ return DOMWrapperWorld::isolatedWorld(v8::Context::GetCurrent());
marja 2013/07/18 09:24:51 What's the difference between GetCurrent() and Get
+}
+
+v8::Local<v8::Value> getHiddenValueFromMainWorldWrapper(v8::Isolate* isolate, ScriptWrappable* wrappable, v8::Handle<v8::String> key)
+{
+ v8::Local<v8::Object> wrapper = wrappable->newLocalWrapper(isolate);
+ return !wrapper.IsEmpty() ? wrapper->GetHiddenValue(key) : v8::Local<v8::Value>();
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/custom/V8CustomEventCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698